Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 857853003: Add DumpAccessibilityTree tests (13,14 of 20) (Closed)

Created:
5 years, 11 months ago by shreeramk
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DumpAccessibilityTree tests (13,14 of 20) BUG=170585, 170586 Committed: https://crrev.com/cd3a95252fc67e462f1743535dd73c87bf198156 Cr-Commit-Position: refs/heads/master@{#312393}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : uploading expectaions #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : #

Patch Set 6 : incorporating comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -0 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 8 chunks +38 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-alertdialog.html View 1 chunk +5 lines, -3 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-alertdialog-expected-android.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
A content/test/data/accessibility/aria/aria-alertdialog-expected-mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-alertdialog-expected-win.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-describedby.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-describedby-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-describedby-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-describedby-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/aria/aria-label.html View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-label-expected-android.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-label-expected-mac.txt View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-label-expected-win.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-option.html View 1 chunk +15 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-option-expected-android.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-option-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-option-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-scrollbar.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-scrollbar-expected-android.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-scrollbar-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-scrollbar-expected-win.txt View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/keygen.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/keygen-expected-android.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/keygen-expected-mac.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/keygen-expected-win.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/optgroup.html View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/html/optgroup-expected-android.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
A content/test/data/accessibility/html/optgroup-expected-mac.txt View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/optgroup-expected-win.txt View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/html/style.html View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/style-expected-android.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/html/style-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/html/style-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/html/sup.html View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/sup-expected-android.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/html/sup-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/html/sup-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!!
5 years, 11 months ago (2015-01-20 17:19:50 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/857853003/diff/60001/content/test/data/accessibility/aria/aria-label-expected-mac.txt File content/test/data/accessibility/aria/aria-label-expected-mac.txt (right): https://codereview.chromium.org/857853003/diff/60001/content/test/data/accessibility/aria/aria-label-expected-mac.txt#newcode2 content/test/data/accessibility/aria/aria-label-expected-mac.txt:2: AXCheckBox AXRoleDescription='check box' AXValue='0' Could you add a ...
5 years, 11 months ago (2015-01-21 07:16:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857853003/100001
5 years, 11 months ago (2015-01-21 14:21:51 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 11 months ago (2015-01-21 15:40:33 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 15:41:50 UTC) #7
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/cd3a95252fc67e462f1743535dd73c87bf198156
Cr-Commit-Position: refs/heads/master@{#312393}

Powered by Google App Engine
This is Rietveld 408576698