Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: Source/core/html/track/vtt/VTTCue.h

Issue 857823003: VTTCue: Make position/line/size double attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Nits. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/media/track/vtt-cue-float-precision.html ('k') | Source/core/html/track/vtt/VTTCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTCue.h
diff --git a/Source/core/html/track/vtt/VTTCue.h b/Source/core/html/track/vtt/VTTCue.h
index 102e2f01d14b7b9b9306f88f15b5586e9a2b2a6e..4bd268803f0e11839074fbd0b49691384525c235 100644
--- a/Source/core/html/track/vtt/VTTCue.h
+++ b/Source/core/html/track/vtt/VTTCue.h
@@ -76,14 +76,14 @@ public:
bool snapToLines() const { return m_snapToLines; }
void setSnapToLines(bool);
- int line() const { return m_linePosition; }
- void setLine(int, ExceptionState&);
+ double line() const { return m_linePosition; }
+ void setLine(double, ExceptionState&);
- int position() const { return m_textPosition; }
- void setPosition(int, ExceptionState&);
+ double position() const { return m_textPosition; }
+ void setPosition(double, ExceptionState&);
- int size() const { return m_cueSize; }
- void setSize(int, ExceptionState&);
+ double size() const { return m_cueSize; }
+ void setSize(double, ExceptionState&);
const String& align() const;
void setAlign(const String&);
@@ -107,12 +107,12 @@ public:
void markFutureAndPastNodes(ContainerNode*, double previousTimestamp, double movieTime);
- int calculateComputedLinePosition();
+ float calculateComputedLinePosition();
FloatPoint getCSSPosition() const;
CSSValueID getCSSAlignment() const;
- int getCSSSize() const;
+ float getCSSSize() const;
CSSValueID getCSSWritingDirection() const;
CSSValueID getCSSWritingMode() const;
@@ -171,10 +171,10 @@ private:
CueSetting settingName(VTTScanner&);
String m_text;
- int m_linePosition;
- int m_computedLinePosition;
- int m_textPosition;
- int m_cueSize;
+ float m_linePosition;
+ float m_computedLinePosition;
+ float m_textPosition;
+ float m_cueSize;
WritingDirection m_writingDirection;
CueAlignment m_cueAlignment;
String m_regionId;
@@ -184,7 +184,7 @@ private:
RefPtrWillBeMember<VTTCueBox> m_displayTree;
CSSValueID m_displayDirection;
- int m_displaySize;
+ float m_displaySize;
FloatPoint m_displayPosition;
bool m_snapToLines : 1;
« no previous file with comments | « LayoutTests/media/track/vtt-cue-float-precision.html ('k') | Source/core/html/track/vtt/VTTCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698