Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: LayoutTests/media/track/vtt-cue-float-precision.html

Issue 857823003: VTTCue: Make position/line/size double attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Nits. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/media/track/vtt-cue-float-precision.html
diff --git a/LayoutTests/media/track/vtt-cue-float-precision.html b/LayoutTests/media/track/vtt-cue-float-precision.html
new file mode 100644
index 0000000000000000000000000000000000000000..556438bca71168067a91fa1161a5580a576e8299
--- /dev/null
+++ b/LayoutTests/media/track/vtt-cue-float-precision.html
@@ -0,0 +1,28 @@
+<!doctype html>
+<title>Float precision of VTTCue attributes line, position and size</title>
+<script src=../../resources/testharness.js></script>
+<script src=../../resources/testharnessreport.js></script>
+<div id=log></div>
+<script>
+test(function() {
+ var cue = new VTTCue(0, 1, 'text');
+
+ // Assign a value which is exactly representable as double but not float.
+ var doubleValue = 1.000000000000004;
+ cue.line = doubleValue;
+ assert_not_equals(cue.line, doubleValue);
+ cue.position = doubleValue;
+ assert_not_equals(cue.position, doubleValue);
+ cue.size = doubleValue;
+ assert_not_equals(cue.size, doubleValue);
+
+ // Assign a value which is exactly representable as float but is non-integral.
+ var floatValue = 1.5;
+ cue.line = floatValue;
+ assert_equals(cue.line, floatValue);
+ cue.position = floatValue;
+ assert_equals(cue.position, floatValue);
+ cue.size = floatValue;
+ assert_equals(cue.size, floatValue);
+}, document.title+', stored as floats');
+</script>
« no previous file with comments | « LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698