LayoutTests/media/track/vtt-cue-float-precision.html - Issue 857823003: VTTCue: Make position/line/size double attributes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/vtt-cue-float-precision.html

Issue 857823003: VTTCue: Make position/line/size double attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <title>Float precision of VTTCue attributes line, position and size</title>

	3 <script src=../../resources/testharness.js></script>

	4 <script src=../../resources/testharnessreport.js></script>

	5 <div id=log></div>

	6 <script>

	7 test(function(){
	philipj_slow 2015/01/20 10:07:38 space before { space before { fs 2015/01/20 10:22:48 Done. Show quoted text On 2015/01/20 10:07:38, philipj wrote: > space before { Done.
	8 var cue = new VTTCue(0, 1, 'text');

	9

	10 // Assign a value which is exactly representable as double but not float.

	11 var doubleValue = 1.000000000000004;

	12 cue.line = doubleValue;

	13 assert_not_equals(cue.line, doubleValue);

	14 cue.position = doubleValue;

	15 assert_not_equals(cue.position, doubleValue);

	16 cue.size = doubleValue;

	17 assert_not_equals(cue.size, doubleValue);

	18

	19 // Assign a value which is exactly representable as float but is non-integra l.

	20 var floatValue = 1.5;

	21 cue.line = floatValue;

	22 assert_equals(cue.line, floatValue);

	23 cue.position = floatValue;

	24 assert_equals(cue.position, floatValue);

	25 cue.size = floatValue;

	26 assert_equals(cue.size, floatValue);

	27 }, document.title+', stored as floats');

	28 </script>

OLD	NEW