Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 857823003: VTTCue: Make position/line/size double attributes (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, arv+blink, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, Inactive, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

VTTCue: Make position/line/size double attributes Changing the IDL types of the attribute to match the specification. Convert all internal storage associated with the attributes into floats (from integers). Add a test (vtt-cue-float-precision.html) to show that the storing as single precision is intentional. BUG=448000 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188663

Patch Set 1 #

Total comments: 6

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -36 lines) Patch
M LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt View 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/media/track/vtt-cue-float-precision.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.h View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 11 chunks +22 lines, -17 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt File LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt (right): https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt#newcode25 LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt:25: {"line":2147483648} This caused by scanDigits clamping to INT_MAX - ...
5 years, 11 months ago (2015-01-19 15:19:32 UTC) #2
philipj_slow
lgtm https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt File LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt (right): https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt#newcode25 LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt:25: {"line":2147483648} On 2015/01/19 15:19:32, fs wrote: > This ...
5 years, 11 months ago (2015-01-20 10:07:38 UTC) #3
fs
https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/vtt-cue-float-precision.html File LayoutTests/media/track/vtt-cue-float-precision.html (right): https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/vtt-cue-float-precision.html#newcode7 LayoutTests/media/track/vtt-cue-float-precision.html:7: test(function(){ On 2015/01/20 10:07:38, philipj wrote: > space before ...
5 years, 11 months ago (2015-01-20 10:22:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857823003/20001
5 years, 11 months ago (2015-01-20 11:16:15 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 12:06:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188663

Powered by Google App Engine
This is Rietveld 408576698