VTTCue: Make position/line/size double attributes

VTTCue: Make position/line/size double attributes

Changing the IDL types of the attribute to match the specification.
Convert all internal storage associated with the attributes into floats
(from integers).
Add a test (vtt-cue-float-precision.html) to show that the storing as
single precision is intentional.

BUG=448000
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188663

[fs, 2015-01-19 15:18:35]

fs@opera.com changed reviewers:
+ philipj@opera.com

[fs, 2015-01-19 15:19:32]

https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/oper...
File
LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt
(right):

https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/oper...
LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt:25:
{"line":2147483648}
This caused by scanDigits clamping to INT_MAX - but a float can't represent
that, so you get the closest thing it can represent...

(When adding support for fractional percentage I suppose this will get bumped
again...)

[philipj_slow, 2015-01-20 10:07:38]

lgtm

https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/oper...
File
LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt
(right):

https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/oper...
LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt:25:
{"line":2147483648}
On 2015/01/19 15:19:32, fs wrote:
> This caused by scanDigits clamping to INT_MAX - but a float can't represent
> that, so you get the closest thing it can represent...
> 
> (When adding support for fractional percentage I suppose this will get bumped
> again...)

Acknowledged.

https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/vtt-...
File LayoutTests/media/track/vtt-cue-float-precision.html (right):

https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/vtt-...
LayoutTests/media/track/vtt-cue-float-precision.html:7: test(function(){
space before {

https://codereview.chromium.org/857823003/diff/1/Source/core/html/track/vtt/V...
File Source/core/html/track/vtt/VTTCue.cpp (left):

https://codereview.chromium.org/857823003/diff/1/Source/core/html/track/vtt/V...
Source/core/html/track/vtt/VTTCue.cpp:121: if (value < 0 || value > 100) {
Maybe ASSERT(std::isfinite(value)) since we're a few steps away from the IDL
that enforces it?

[fs, 2015-01-20 10:22:49]

https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/vtt-...
File LayoutTests/media/track/vtt-cue-float-precision.html (right):

https://codereview.chromium.org/857823003/diff/1/LayoutTests/media/track/vtt-...
LayoutTests/media/track/vtt-cue-float-precision.html:7: test(function(){
On 2015/01/20 10:07:38, philipj wrote:
> space before {

Done.

https://codereview.chromium.org/857823003/diff/1/Source/core/html/track/vtt/V...
File Source/core/html/track/vtt/VTTCue.cpp (left):

https://codereview.chromium.org/857823003/diff/1/Source/core/html/track/vtt/V...
Source/core/html/track/vtt/VTTCue.cpp:121: if (value < 0 || value > 100) {
On 2015/01/20 10:07:38, philipj wrote:
> Maybe ASSERT(std::isfinite(value)) since we're a few steps away from the IDL
> that enforces it?

Done.

[fs, 2015-01-20 11:15:16]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-01-20 11:16:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/857823003/20001

[commit-bot: I haz the power, 2015-01-20 12:06:56]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188663