Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 857783002: [turbofan] Make Factory::NewNumber() always return the minus_zero_value. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make Factory::NewNumber() always return the minus_zero_value. TEST=unittests Committed: https://crrev.com/f578d35ba8d6798afe45cd60f4f06bfa7e2ae6be Cr-Commit-Position: refs/heads/master@{#26124}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : More tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
A test/unittests/factory-unittest.cc View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-19 07:29:55 UTC) #2
Sven Panne
lgtm
5 years, 11 months ago (2015-01-19 07:46:26 UTC) #3
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-19 07:47:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857783002/40001
5 years, 11 months ago (2015-01-19 07:47:45 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-19 08:07:36 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 08:07:47 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f578d35ba8d6798afe45cd60f4f06bfa7e2ae6be
Cr-Commit-Position: refs/heads/master@{#26124}

Powered by Google App Engine
This is Rietveld 408576698