Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: pkg/compiler/lib/src/js_backend/native_emitter.dart

Issue 857573002: Revert "dart2js: Only emit constructors of the native class interceptors that are used." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/native_emitter.dart
diff --git a/pkg/compiler/lib/src/js_backend/native_emitter.dart b/pkg/compiler/lib/src/js_backend/native_emitter.dart
index f491257c74acdb5b5837802d598642434649dcdb..60f11553430e71639cbfa93dd9780a1d1020a973 100644
--- a/pkg/compiler/lib/src/js_backend/native_emitter.dart
+++ b/pkg/compiler/lib/src/js_backend/native_emitter.dart
@@ -232,27 +232,10 @@ class NativeEmitter {
for (ClassElement classElement in classes) {
if (!classElement.isNative) continue;
if (neededClasses.contains(classElement)) {
- ClassBuilder builder = builders[classElement];
-
- // In CSP mode [emitClassConstructor] and [emitClassGettersSetters] have
- // a side-effect on "precompiled" functions in [OldEmitter]. For this
- // reason, it is important that we don't call these methods before we
- // are certain that a class is needed.
-
- // [emitClassConstructor] only affects the generation of constructors
- // in CSP mode.
- emitterTask.oldEmitter.classEmitter.emitClassConstructor(
- classElement, builder);
-
- // [emitClassGettersSetters] does not affect whether or not a class is
- // needed. If getters/setters are emitted, the class has fields and
- // is therefore non-trivial.
- emitterTask.oldEmitter.classEmitter.emitClassGettersSetters(
- classElement, builder);
-
// Define interceptor class for [classElement].
emitterTask.oldEmitter.classEmitter.emitClassBuilderWithReflectionData(
- backend.namer.getNameOfClass(classElement), classElement, builder,
+ backend.namer.getNameOfClass(classElement),
+ classElement, builders[classElement],
emitterTask.oldEmitter.getElementDescriptor(classElement));
emitterTask.oldEmitter.needsClassSupport = true;
}
@@ -318,10 +301,13 @@ class NativeEmitter {
}
builder.superName = superName;
+ emitterTask.oldEmitter.classEmitter.emitClassConstructor(
+ classElement, builder);
bool hasFields = emitterTask.oldEmitter.classEmitter.emitFields(
classElement, builder, classIsNative: true);
int propertyCount = builder.properties.length;
-
+ emitterTask.oldEmitter.classEmitter.emitClassGettersSetters(
+ classElement, builder);
emitterTask.oldEmitter.classEmitter.emitInstanceMembers(
classElement, builder);
emitterTask.oldEmitter.typeTestEmitter.emitIsTests(classElement, builder);
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698