Issue 857533002: Add support for GestureEvents to Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 857533002: Add support for GestureEvents to Sky (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add support for GestureEvents to Sky We'll likely change the API over time, but this is a start. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/efe670c879c44941fba5329680e6e73e5fb5b4f4

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -16 lines)			Patch
M	sky/engine/core/core.gni	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/Node.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/events/GestureEvent.h	View	1 chunk	+28 lines, -3 lines	0 comments	Download
M	sky/engine/core/events/GestureEvent.cpp	View	4 chunks	+40 lines, -12 lines	0 comments	Download
A	sky/engine/core/events/GestureEvent.idl	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	sky/tests/events/gesture-events.sky	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	sky/tests/events/gesture-events-expected.txt	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

esprehn

Chai has assert.isInstanceOf that will give better error messages. Also don't abbreviate event, we did ...

5 years, 11 months ago (2015-01-16 20:28:03 UTC) #2

abarth-chromium

5 years, 11 months ago (2015-01-16 23:42:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
efe670c879c44941fba5329680e6e73e5fb5b4f4 (presubmit successful).