Chromium Code Reviews
Help | Chromium Project | Sign in
(65)

Issue 8575013: Offline state detection for linux, using new D-Bus library. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by adamk
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Offline state detection for linux, using new D-Bus library. Relanding with fix for component build: use NET_EXPORT_PRIVATE in network_change_notifier_linux.h. BUG=53473 TEST=see attachment on bug 7469 R=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -13 lines) Patch
M net/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/network_change_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/network_change_notifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/network_change_notifier_linux.h View 1 chunk +12 lines, -2 lines 0 comments Download
M net/base/network_change_notifier_linux.cc View 11 chunks +233 lines, -10 lines 0 comments Download
A net/base/network_change_notifier_linux_unittest.cc View 1 chunk +227 lines, -0 lines 0 comments Download
M net/net.gyp View 3 chunks +15 lines, -0 lines 0 comments Download
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 2 (0 generated)
adamk
3 years, 8 months ago (2011-11-16 20:29:42 UTC) #1
willchan no longer on Chromium
3 years, 8 months ago (2011-11-16 20:30:15 UTC) #2
LGTM

On Wed, Nov 16, 2011 at 3:29 PM, <adamk@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Offline state detection for linux, using new D-Bus library.
>
> Relanding with fix for component build: use NET_EXPORT_PRIVATE
> in network_change_notifier_linux.**h.
>
> BUG=53473
> TEST=see attachment on bug 7469
> R=willchan@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/8575013/<http://codereview.chromium.org/8575...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M net/DEPS
>  M net/base/network_change_**notifier.h
>  M net/base/network_change_**notifier.cc
>  M net/base/network_change_**notifier_linux.h
>  M net/base/network_change_**notifier_linux.cc
>  A net/base/network_change_**notifier_linux_unittest.cc
>  M net/net.gyp
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f