Issue 8575013: Offline state detection for linux, using new D-Bus library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8575013: Offline state detection for linux, using new D-Bus library. (Closed)

Created:
9 years, 1 month ago by adamk

Modified:
9 years, 1 month ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Offline state detection for linux, using new D-Bus library. Relanding with fix for component build: use NET_EXPORT_PRIVATE in network_change_notifier_linux.h. BUG=53473 TEST=see attachment on bug 7469 R=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110374

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+490 lines, -13 lines)			Patch
M	net/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/base/network_change_notifier.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/base/network_change_notifier.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/network_change_notifier_linux.h	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	net/base/network_change_notifier_linux.cc	View	11 chunks	+233 lines, -10 lines	0 comments	Download
A	net/base/network_change_notifier_linux_unittest.cc	View	1 chunk	+227 lines, -0 lines	0 comments	Download
M	net/net.gyp	View	3 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

9 years, 1 month ago (2011-11-16 20:30:15 UTC) #2

LGTM

On Wed, Nov 16, 2011 at 3:29 PM, <adamk@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Offline state detection for linux, using new D-Bus library.
>
> Relanding with fix for component build: use NET_EXPORT_PRIVATE
> in network_change_notifier_linux.**h.
>
> BUG=53473
> TEST=see attachment on bug 7469
> R=willchan@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/8575013/<http://codereview.chromium.org/8575...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M net/DEPS
>  M net/base/network_change_**notifier.h
>  M net/base/network_change_**notifier.cc
>  M net/base/network_change_**notifier_linux.h
>  M net/base/network_change_**notifier_linux.cc
>  A net/base/network_change_**notifier_linux_unittest.cc
>  M net/net.gyp
>
>
>

Expand Messages | Collapse Messages