Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 857483004: Enable ChannelMojo (Closed)

Created:
5 years, 11 months ago by Hajime Morrita
Modified:
5 years, 10 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ChannelMojo As we addressed certain amount of the performance problem, it's time to give it another try. R=viettrungluu@chromium.org BUG=377980 Committed: https://crrev.com/a06cd1b2fe83b51b0874ca504066f00a17192026 Cr-Commit-Position: refs/heads/master@{#313184}

Patch Set 1 #

Patch Set 2 : Landing #

Patch Set 3 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
Hajime Morrita
5 years, 11 months ago (2015-01-15 23:27:56 UTC) #1
viettrungluu
lgtm
5 years, 11 months ago (2015-01-16 01:30:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857483004/1
5 years, 11 months ago (2015-01-16 18:21:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/45810)
5 years, 11 months ago (2015-01-16 19:13:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857483004/1
5 years, 11 months ago (2015-01-16 21:28:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/46089)
5 years, 11 months ago (2015-01-16 22:23:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857483004/1
5 years, 11 months ago (2015-01-23 18:13:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/46175)
5 years, 11 months ago (2015-01-23 19:05:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857483004/20001
5 years, 11 months ago (2015-01-23 21:21:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/48220)
5 years, 11 months ago (2015-01-23 23:01:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857483004/20001
5 years, 10 months ago (2015-01-26 22:13:39 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/48220)
5 years, 10 months ago (2015-01-26 22:14:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857483004/40001
5 years, 10 months ago (2015-01-27 00:10:28 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-27 01:05:00 UTC) #25
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a06cd1b2fe83b51b0874ca504066f00a17192026 Cr-Commit-Position: refs/heads/master@{#313184}
5 years, 10 months ago (2015-01-27 01:05:41 UTC) #26
yoichio
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/875333002/ by yoichio@chromium.org. ...
5 years, 10 months ago (2015-01-27 04:14:49 UTC) #27
Mr4D (OOO till 08-26)
5 years, 9 months ago (2015-03-12 22:32:39 UTC) #28
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1002973002/ by skuhne@chromium.org.

The reason for reverting is: This is breaking a lot of things (He's dead jim
pages, extensions, and other things). See issue 462026..

Powered by Google App Engine
This is Rietveld 408576698