Report SyntaxError on Token::ILLEGAL in ParseTemplateLiteral

Report SyntaxError on Token::ILLEGAL in ParseTemplateLiteral

BUG=v8:3820, v8:3821
LOG=N
R=arv@chromium.org, dslomov@chromium.org, marja@chromium.org

Committed: https://crrev.com/02218adb6b310e1631f54dcc9d8643e4981e8a3c
Cr-Commit-Position: refs/heads/master@{#26132}

[caitp (gmail), 2015-01-19 11:16:44]

PTAL

I guess `!token` isn't good enough for Token::EOS and Token::ILLEGAL :(

[Dmitry Lomov (no reviews), 2015-01-19 11:56:02]

lgtm (happy to see no changes in parser needed!)

This should be escalated and merged into M41, I think.

[caitp (gmail), 2015-01-19 12:08:40]

caitpotter88@gmail.com changed reviewers:
+ marja@chromium.org

[caitp (gmail), 2015-01-19 12:09:50]

/CC marja@

[marja, 2015-01-19 12:10:43]

lgtm 2

[caitp (gmail), 2015-01-19 12:14:35]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2015-01-19 12:14:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/857433004/1

[commit-bot: I haz the power, 2015-01-19 12:38:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-19 12:38:28]

Patchset 1 (id:??) landed as
https://crrev.com/02218adb6b310e1631f54dcc9d8643e4981e8a3c
Cr-Commit-Position: refs/heads/master@{#26132}

[caitp (gmail), 2015-01-19 16:08:49]

On 2015/01/19 11:56:02, Dmitry Lomov (chromium) wrote:
> This should be escalated and merged into M41, I think.

I think so. Segfaults in enabled-by-default features is not good :(

[arv (Not doing code reviews), 2015-01-19 17:24:32]

LGTM

https://codereview.chromium.org/857433004/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/857433004/diff/1/src/preparser.h#newcode2979
src/preparser.h:2979: } else if (next == Token::ILLEGAL) {
Can this code duplication be prevented?

[caitp (gmail), 2015-01-19 17:27:04]

https://codereview.chromium.org/857433004/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/857433004/diff/1/src/preparser.h#newcode2979
src/preparser.h:2979: } else if (next == Token::ILLEGAL) {
On 2015/01/19 17:24:32, arv wrote:
> Can this code duplication be prevented?

The first `else if (next == Token::ILLEGAL)` block might not be needed, since
ParseExpression should handle it. But I'm not exactly sure.