Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 857423003: Convert two counter tests into reftests (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Convert two counter tests into reftests These two counter tests always fail on my Linux desktop, however only due to slight font differences, the counter functionality part works fine. So since the font part is not essential to the tests, add reftests and remove old test expectations. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188904

Patch Set 1 #

Patch Set 2 : Add expetced result #

Patch Set 3 : Add the second counter test #

Patch Set 4 : Remove unrelated test #

Patch Set 5 : Retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -3480 lines) Patch
A LayoutTests/css2.1/t1202-counter-09-b-expected.html View 1 4 1 chunk +111 lines, -0 lines 0 comments Download
A LayoutTests/css2.1/t1202-counters-09-b-expected.html View 1 2 4 1 chunk +111 lines, -0 lines 0 comments Download
D LayoutTests/platform/android/css2.1/t1202-counter-09-b-expected.txt View 1 2 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/android/css2.1/t1202-counters-09-b-expected.txt View 1 2 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/linux/css2.1/t1202-counter-09-b-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/css2.1/t1202-counter-09-b-expected.txt View 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/linux/css2.1/t1202-counters-09-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/linux/css2.1/t1202-counters-09-b-expected.txt View 1 2 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/mac-mountainlion/css2.1/t1202-counter-09-b-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/css2.1/t1202-counters-09-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt View 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt View 1 2 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/mac/css2.1/t1202-counter-09-b-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/css2.1/t1202-counter-09-b-expected.txt View 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/mac/css2.1/t1202-counters-09-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac/css2.1/t1202-counters-09-b-expected.txt View 1 2 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/win-xp/css2.1/t1202-counter-09-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win-xp/css2.1/t1202-counter-09-b-expected.txt View 1 2 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/win-xp/css2.1/t1202-counters-09-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win-xp/css2.1/t1202-counters-09-b-expected.txt View 1 2 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/win/css2.1/t1202-counter-09-b-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/css2.1/t1202-counter-09-b-expected.txt View 1 chunk +0 lines, -290 lines 0 comments Download
D LayoutTests/platform/win/css2.1/t1202-counters-09-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win/css2.1/t1202-counters-09-b-expected.txt View 1 2 1 chunk +0 lines, -290 lines 0 comments Download

Messages

Total messages: 31 (14 generated)
rwlbuis
PTAL
5 years, 11 months ago (2015-01-21 22:12:23 UTC) #2
Dirk Pranke
rubber-stamp lgtm.
5 years, 11 months ago (2015-01-22 22:32:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857423003/40001
5 years, 11 months ago (2015-01-22 22:46:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/43293)
5 years, 11 months ago (2015-01-23 00:19:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857423003/40001
5 years, 11 months ago (2015-01-23 00:24:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/43308)
5 years, 11 months ago (2015-01-23 01:45:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857423003/40001
5 years, 11 months ago (2015-01-23 02:36:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/43328)
5 years, 11 months ago (2015-01-23 03:53:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857423003/40001
5 years, 11 months ago (2015-01-23 12:03:41 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/41963) linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/43393)
5 years, 11 months ago (2015-01-23 13:21:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857423003/40001
5 years, 11 months ago (2015-01-23 15:27:50 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/43422)
5 years, 11 months ago (2015-01-23 16:43:38 UTC) #23
rwlbuis
On 2015/01/23 16:43:38, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-23 16:46:49 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857423003/60001
5 years, 11 months ago (2015-01-23 16:56:37 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/43443)
5 years, 11 months ago (2015-01-23 18:19:19 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857423003/80001
5 years, 11 months ago (2015-01-23 19:55:56 UTC) #30
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 21:11:48 UTC) #31
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188904

Powered by Google App Engine
This is Rietveld 408576698