Enable find-missing-symbols-at-link-time for chromeos builds too.

Enable find-missing-symbols-at-link-time for chromeos builds too.

Add missing dependencies that caused build failures with this flag.

(I did similar changes in the BUILD.gn files too, but blindly.)

BUG=371125
R=derat@chromium.org, thestig@chromium.org
TBR=antrim, bshe, thestig, timvolodine

Committed: https://chromium.googlesource.com/chromium/src/+/a3d0a42c580f072bad3afd36f3f26b4d79e35900

[Nico, 2015-01-20 20:55:44]

thakis@chromium.org changed reviewers:
+ derat@chromium.org

[Nico, 2015-01-20 20:55:44]

derat: everything

jamesr: gn stuff fyi

https://codereview.chromium.org/857353004/diff/1/content/content_browser.gypi
File content/content_browser.gypi (right):

https://codereview.chromium.org/857353004/diff/1/content/content_browser.gypi...
content/content_browser.gypi:1884: '../chromeos/chromeos.gyp:chromeos',
(this is already there in the BUILD.gn file)

[Daniel Erat, 2015-01-20 21:02:17]

lgtm if it builds

https://codereview.chromium.org/857353004/diff/20001/ui/display/BUILD.gn
File ui/display/BUILD.gn (right):

https://codereview.chromium.org/857353004/diff/20001/ui/display/BUILD.gn#newc...
ui/display/BUILD.gn:59: if (is_chromeos && use_x11) {
nit: any reason not to nest this within the previous condition?

[Nico, 2015-01-20 21:06:43]

https://codereview.chromium.org/857353004/diff/20001/ui/display/BUILD.gn
File ui/display/BUILD.gn (right):

https://codereview.chromium.org/857353004/diff/20001/ui/display/BUILD.gn#newc...
ui/display/BUILD.gn:59: if (is_chromeos && use_x11) {
On 2015/01/20 21:02:17, Daniel Erat wrote:
> nit: any reason not to nest this within the previous condition?

Done.

[Nico, 2015-01-20 21:08:48]

Thanks! tbr'ing.

antrim: for components/user_manager
bshe: for components/wallpaper
timvolodine: for device/battery
thestig: for third_party/libexif

[Nico, 2015-01-20 21:08:58]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-20 21:09:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/857353004/40001

[Nico, 2015-01-20 21:10:21]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-20 21:10:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/857353004/60001

[Nico, 2015-01-20 21:14:05]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-20 21:14:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/857353004/80001

[Lei Zhang, 2015-01-20 21:15:11]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-01-20 21:15:11]

lgtm

[commit-bot: I haz the power, 2015-01-20 21:48:45]

Patchset 5 (id:??) landed as
https://crrev.com/a3d0a42c580f072bad3afd36f3f26b4d79e35900
Cr-Commit-Position: refs/heads/master@{#312280}

[Nico, 2015-01-20 21:48:53]

Committed patchset #5 (id:80001) manually as
a3d0a42c580f072bad3afd36f3f26b4d79e35900 (presubmit successful).