Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 85733003: Make test runner more flexible for running fast tests. (Closed)

Created:
7 years ago by Michael Achenbach
Modified:
7 years ago
Reviewers:
Yang
CC:
v8-dev, Jakob Kummerow
Visibility:
Public.

Description

Make test runner more flexible for running fast tests. Transformed variant flags into named variants. Now, all combinations of variants can be specified on the command line. The old command-line flags are kept for backwards compatibility on the bots. Added two new test groups: slow and pass|fail. Both are implemented similar to the flaky test feature and allow to either skip or run tests marked as slow or as pass|fail. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18062

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -20 lines) Patch
M test/mozilla/mozilla.status View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/run-tests.py View 6 chunks +43 lines, -13 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 1 chunk +5 lines, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 3 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years ago (2013-11-25 13:57:03 UTC) #1
Yang
On 2013/11/25 13:57:03, machenbach wrote: > PTAL LGTM.
7 years ago (2013-11-25 15:31:47 UTC) #2
Michael Achenbach
7 years ago (2013-11-25 17:35:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18062 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698