Refactor sudden termination

content/public/browser/render_process_host.h

Index: content/public/browser/render_process_host.h
diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h
index 6ee9f2bab7d4e02ba79c5b287495e5cbb949d8bc..7b6f3c93788b885e03eec1115d1142dc184ad708 100644
--- a/content/public/browser/render_process_host.h
+++ b/content/public/browser/render_process_host.h
@@ -179,8 +179,8 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
   virtual void AddPendingView() = 0;
   virtual void RemovePendingView() = 0;
 
-  // Sets a flag indicating that the process can be abnormally terminated.
-  virtual void SetSuddenTerminationAllowed(bool allowed) = 0;
+  // Called when the sudden termination status of a frame has changed.
+  virtual void SuddenTerminationChangedForFrame(bool allowed) = 0;

[Charlie Reis, 2015/01/23 06:01:32]

This doesn't belong in the public API (nor did SetSuddenTerminationAllowed,
which was only called within RPHI and was unnecessarily overidden in MockRPH).

[clamy, 2015/01/26 16:38:40]

The problem with not having these functions in the public API is that calling
them will require a cast to RenderProcessHostImpl in the middle of the code.
Since MockProcessHost does not inherit from RenderProcessHostImpl, this will
cause breakages in unit tests.

Given that this particular one was removed, that solves the problem though.

   // Returns true if the process can be abnormally terminated.

[Charlie Reis, 2015/01/23 06:01:32]

abnormally terminated -> immediately terminated

[clamy, 2015/01/26 16:38:40]

Done.

   virtual bool SuddenTerminationAllowed() const = 0;