Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 857213003: Refactor sudden termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Charlie's comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 3223ecb35b8973408de1461e57bff69d18d72824..abba0801004878594e68b724c6a9995380055087 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -1493,7 +1493,7 @@ bool RenderProcessHostImpl::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(ChildProcessHostMsg_DumpHandlesDone,
OnDumpHandlesDone)
IPC_MESSAGE_HANDLER(ViewHostMsg_SuddenTerminationChanged,
- SuddenTerminationChanged)
+ OnSuddenTerminationChanged)
IPC_MESSAGE_HANDLER(ViewHostMsg_UserMetricsRecordAction,
OnUserMetricsRecordAction)
IPC_MESSAGE_HANDLER(ViewHostMsg_SavedPageAsMHTML, OnSavedPageAsMHTML)
@@ -1658,10 +1658,6 @@ void RenderProcessHostImpl::RemovePendingView() {
pending_views_--;
}
-void RenderProcessHostImpl::SetSuddenTerminationAllowed(bool enabled) {
- sudden_termination_allowed_ = enabled;
-}
-
bool RenderProcessHostImpl::SuddenTerminationAllowed() const {
return sudden_termination_allowed_;
}
@@ -2170,8 +2166,8 @@ void RenderProcessHostImpl::OnShutdownRequest() {
Send(new ChildProcessMsg_Shutdown());
}
-void RenderProcessHostImpl::SuddenTerminationChanged(bool enabled) {
- SetSuddenTerminationAllowed(enabled);
+void RenderProcessHostImpl::OnSuddenTerminationChanged(bool enabled) {
+ sudden_termination_allowed_ = enabled;
}
void RenderProcessHostImpl::OnDumpHandlesDone() {

Powered by Google App Engine
This is Rietveld 408576698