Refactor sudden termination

content/browser/renderer_host/render_process_host_impl.h

Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index 1ed902def6e0315455dff73b750aa155cb9f671f..cf844c909e406349a9998a46443632f7a4443f47 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -121,7 +121,6 @@ class CONTENT_EXPORT RenderProcessHostImpl
   void Cleanup() override;
   void AddPendingView() override;
   void RemovePendingView() override;
-  void SetSuddenTerminationAllowed(bool enabled) override;
   bool SuddenTerminationAllowed() const override;
   IPC::ChannelProxy* GetChannel() override;
   void AddFilter(BrowserMessageFilter* filter) override;
@@ -314,7 +313,7 @@ class CONTENT_EXPORT RenderProcessHostImpl
   // Control message handlers.
   void OnShutdownRequest();
   void OnDumpHandlesDone();
-  void SuddenTerminationChanged(bool enabled);
+  void OnSuddenTerminationChanged(bool enabled);
   void OnUserMetricsRecordAction(const std::string& action);
   void OnSavedPageAsMHTML(int job_id, int64 mhtml_file_size);
   void OnCloseACK(int old_route_id);
@@ -415,12 +414,12 @@ class CONTENT_EXPORT RenderProcessHostImpl
   // The observers watching our lifetime.
   ObserverList<RenderProcessHostObserver> observers_;
 
-  // True if the process can be shut down suddenly.  If this is true, then we're
-  // sure that all the RenderViews in the process can be shutdown suddenly.  If
-  // it's false, then specific RenderViews might still be allowed to be shutdown
-  // suddenly by checking their SuddenTerminationAllowed() flag.  This can occur
-  // if one WebContents has an unload event listener but another WebContents in
-  // the same process doesn't.
+  // Whether the sudden termination of the process is allowed at a process
+  // level. This is independent from the status of the various RenderFrames in

[Charlie Reis, 2015/02/04 21:34:58]

I don't think "This is independent" is very clear, since the status of the
RenderFrames is a subset of the conditions determining this flag.

The old comment seems clearer to me, once we change "RenderViews" and
"WebContents" to "RenderFrames."

[clamy, 2015/02/05 16:23:13]

Done.

+  // the process: even if this is false, some RenderFrames may be shutdown
+  // suddenly if their SuddenTerminationAllowed() flag is true. This can happen
+  // when a RenderFrame has an unload/beforeUnload event listener registerd but
+  // another RenderFrame in the same process doesn't.
   bool sudden_termination_allowed_;
 
   // Set to true if we shouldn't send input events.  We actually do the