Refactor sudden termination

content/public/browser/render_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 
 #include "base/basictypes.h"
 #include "base/id_map.h"
 #include "base/process/kill.h"
@@ skipping 161 matching lines @@
 
   // Schedules the host for deletion and removes it from the all_hosts list.
   virtual void Cleanup() = 0;
 
   // Track the count of pending views that are being swapped back in.  Called
   // by listeners to register and unregister pending views to prevent the
   // process from exiting.
   virtual void AddPendingView() = 0;
   virtual void RemovePendingView() = 0;
 
-  // Sets a flag indicating that the process can be abnormally terminated.
-  virtual void SetSuddenTerminationAllowed(bool allowed) = 0;
+  // Called when the sudden termination status of a frame has changed.
+  virtual void SuddenTerminationChangedForFrame(bool allowed) = 0;

[Charlie Reis, 2015/01/23 06:01:32]

This doesn't belong in the public API (nor did SetSuddenTerminationAllowed,
which was only called within RPHI and was unnecessarily overidden in MockRPH).

[clamy, 2015/01/26 16:38:40]

The problem with not having these functions in the public API is that calling
them will require a cast to RenderProcessHostImpl in the middle of the code.
Since MockProcessHost does not inherit from RenderProcessHostImpl, this will
cause breakages in unit tests.

Given that this particular one was removed, that solves the problem though.

   // Returns true if the process can be abnormally terminated.

[Charlie Reis, 2015/01/23 06:01:32]

abnormally terminated -> immediately terminated

[clamy, 2015/01/26 16:38:40]

Done.

   virtual bool SuddenTerminationAllowed() const = 0;
 
   // Returns how long the child has been idle. The definition of idle
   // depends on when a derived class calls mark_child_process_activity_time().
   // This is a rough indicator and its resolution should not be better than
   // 10 milliseconds.
   virtual base::TimeDelta GetChildProcessIdleTime() const = 0;
 
   // Called to resume the requests for a view created through window.open that
   // were initially blocked.
@@ skipping 111 matching lines @@
   static void SetMaxRendererProcessCount(size_t count);
 
   // Returns the current maximum number of renderer process hosts kept by the
   // content module.
   static size_t GetMaxRendererProcessCount();
 };
 
 }  // namespace content.
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_