Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 857193004: [NOT READY FOR REVIEW YET]workers: Some refactoring to allow creating new kind of worker threads

Created:
5 years, 11 months ago by sadrul
Modified:
4 years, 6 months ago
Reviewers:
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, falken, hartmanng, horo+watch_chromium.org, kinuko+worker_chromium.org, Ian Vollick
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

workers: Some refactoring to allow creating new kind of worker threads Notable changes: * The WorkerThread is now responsible for creating the v8::Isolate for running the script. * WorkerScriptController receives a v8::Isolate from the WorkerThread during construction. * Allow sub-classing WebThreadSupportingGC. The default implementation remains the same as before. But this will allow creating WebThreadSupportingGC objects that share a single WebThread object (instead of each WebThreadSupportingGC owning its own WebThread instance, which is the current implementation). BUG=none

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -59 lines) Patch
M Source/bindings/core/v8/WorkerScriptController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/workers/Worker.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/Worker.cpp View 1 2 chunks +21 lines, -14 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerThread.h View 1 4 chunks +10 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 5 chunks +24 lines, -1 line 0 comments Download
M Source/platform/WebThreadSupportingGC.h View 1 chunk +9 lines, -32 lines 0 comments Download
M Source/platform/WebThreadSupportingGC.cpp View 1 3 chunks +36 lines, -6 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698