tools/gn/substitution_writer_unittest.cc - Issue 857163002: Absolute path fixes for gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/substitution_writer_unittest.cc

Issue 857163002: Absolute path fixes for gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improve error message Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/substitution_writer_unittest.cc

diff --git a/tools/gn/substitution_writer_unittest.cc b/tools/gn/substitution_writer_unittest.cc

index b59475b8cfaa1829f79641230398bc9f65b5dfee..f5dcb78ff0f256e10083e410b968193327b89cb2 100644

--- a/tools/gn/substitution_writer_unittest.cc

+++ b/tools/gn/substitution_writer_unittest.cc

@@ -161,7 +161,12 @@ TEST(SubstitutionWriter, SourceSubstitutions) {

EXPECT_EQ("/baz.txt", GetRelSubst("/baz.txt", SUBSTITUTION_SOURCE));

EXPECT_EQ("/.", GetRelSubst("/baz.txt", SUBSTITUTION_SOURCE_DIR));

EXPECT_EQ("gen", GetRelSubst("/baz.txt", SUBSTITUTION_SOURCE_GEN_DIR));

- EXPECT_EQ("obj", GetRelSubst("/baz.txt", SUBSTITUTION_SOURCE_OUT_DIR));

+ EXPECT_EQ("obj/ABS_PATH",

+ GetRelSubst("/baz.txt", SUBSTITUTION_SOURCE_OUT_DIR));

+#if defined(OS_WIN)

+ EXPECT_EQ("obj/ABS_PATH/C",

+ GetRelSubst("/C:/baz.txt", SUBSTITUTION_SOURCE_OUT_DIR));

+#endif

EXPECT_EQ(".",

GetRelSubst("//baz.txt", SUBSTITUTION_SOURCE_ROOT_RELATIVE_DIR));

« no previous file with comments | « tools/gn/source_dir.cc ('k') | no next file » | no next file with comments »