tools/gn/function_get_path_info_unittest.cc - Issue 857163002: Absolute path fixes for gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/function_get_path_info_unittest.cc

Issue 857163002: Absolute path fixes for gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Windows fixes and additional tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/function_get_path_info_unittest.cc

diff --git a/tools/gn/function_get_path_info_unittest.cc b/tools/gn/function_get_path_info_unittest.cc

index 855e217accf508b52379003854118564185606fc..306c57e88c134082dc4edca32fe7887b9f6f426b 100644

--- a/tools/gn/function_get_path_info_unittest.cc

+++ b/tools/gn/function_get_path_info_unittest.cc

@@ -95,8 +95,12 @@ TEST_F(GetPathInfoTest, OutDir) {

EXPECT_EQ("//out/Debug/obj/src/foo", Call(".", "out_dir"));

EXPECT_EQ("//out/Debug/obj/src/foo", Call("bar", "out_dir"));

EXPECT_EQ("//out/Debug/obj/foo", Call("//foo/bar.txt", "out_dir"));

- // System paths go into the root obj directory.

- EXPECT_EQ("//out/Debug/obj", Call("/foo/bar.txt", "out_dir"));

+ // System paths go into the ABS_PATH obj directory.

+ EXPECT_EQ("//out/Debug/obj/ABS_PATH/foo", Call("/foo/bar.txt", "out_dir"));

+#if defined(OS_WIN)

+ EXPECT_EQ("//out/Debug/obj/ABS_PATH/C/foo",

+ Call("/C:/foo/bar.txt", "out_dir"));

+#endif

}

// Note build dir is "//out/Debug/".