Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/label_pattern.cc

Issue 857163002: Absolute path fixes for gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/label.cc ('K') | « tools/gn/label.cc ('k') | tools/gn/source_dir.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/label_pattern.cc
diff --git a/tools/gn/label_pattern.cc b/tools/gn/label_pattern.cc
index 396a9b73a9d4fc1f269d926496b2dda5d0a46e89..331a3858869b354b18d085bc9baa7c40987bd07c 100644
--- a/tools/gn/label_pattern.cc
+++ b/tools/gn/label_pattern.cc
@@ -121,7 +121,14 @@ LabelPattern LabelPattern::GetPattern(const SourceDir& current_dir,
// Extract path and name.
base::StringPiece path;
base::StringPiece name;
- size_t colon = str.find(':');
+ size_t offset = 0;
+#if defined(OS_WIN)
+ if (IsPathAbsolute(str)) {
brettw 2015/01/20 21:05:00 Ditto
+ // Skip over the drive letter colon.
+ offset = 3;
+ }
+#endif
+ size_t colon = str.find(':', offset);
if (colon == std::string::npos) {
path = base::StringPiece(str);
} else {
« tools/gn/label.cc ('K') | « tools/gn/label.cc ('k') | tools/gn/source_dir.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698