Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 857153003: Use "static_assert" in lieu of "COMPILE_ASSERT" in courgete (Closed)

Created:
5 years, 11 months ago by anujsharma
Modified:
5 years, 11 months ago
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using "static_assert" in lieu of "COMPILE_ASSERT" in courgete module All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now. BUG=442514 Committed: https://crrev.com/1b06a96c05f8ef9e27b23ccbfe5f4976ed8ef123 Cr-Commit-Position: refs/heads/master@{#312203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M courgette/difference_estimator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M courgette/encoded_program.cc View 1 chunk +1 line, -1 line 0 comments Download
M courgette/third_party/bsdiff_apply.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M courgette/third_party/bsdiff_create.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M courgette/types_win_pe.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
anujsharma
PTAL
5 years, 11 months ago (2015-01-20 12:43:10 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 11 months ago (2015-01-20 14:20:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857153003/1
5 years, 11 months ago (2015-01-20 14:21:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 15:55:28 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 15:56:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b06a96c05f8ef9e27b23ccbfe5f4976ed8ef123
Cr-Commit-Position: refs/heads/master@{#312203}

Powered by Google App Engine
This is Rietveld 408576698