extensions/common/api/guest_view_internal.json - Issue 857093003: Implemented explicit resizing from guestview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/guest_view_internal.json

Issue 857093003: Implemented explicit resizing from guestview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/guest_view_base.cc ('K') | « extensions/browser/guest_view/guest_view_base.cc ('k') | extensions/common/guest_view/guest_view_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/guest_view_internal.json

diff --git a/extensions/common/api/guest_view_internal.json b/extensions/common/api/guest_view_internal.json

index 46564e54785d46d91d58256d71532574c343fcfe..ddf8ce9457ceeea32e2597c5c34dc5d662e8ca58 100644

--- a/extensions/common/api/guest_view_internal.json

+++ b/extensions/common/api/guest_view_internal.json

@@ -23,18 +23,25 @@

}

{

- "id": "AutoSizeParams",

+ "id": "SizeParams",

"type": "object",

- "description": "Autosize parameters.",

+ "description": "Size parameters.",

"properties": {

"enableAutoSize": {

- "type": "boolean"

+ "type": "boolean",

+ "optional": true

"min": {

- "$ref": "Size"

+ "$ref": "Size",

+ "optional": true

"max": {

- "$ref": "Size"

+ "$ref": "Size",

+ "optional": true

+ },

+ "normal": {

+ "$ref": "Size",

+ "optional": true

}

@@ -83,7 +90,7 @@

]

{

- "name": "setAutoSize",

+ "name": "setSize",

"type": "function",

"parameters": [

{

@@ -92,7 +99,7 @@

"description": "The instance ID of the guest <webview> process. This not exposed to developers through the API."

{

- "$ref": "AutoSizeParams",

+ "$ref": "SizeParams",

"name": "params"

{