Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 857093003: Implemented explicit resizing from guestview. (Closed)

Created:
5 years, 11 months ago by paulmeyer
Modified:
5 years, 11 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented explicit resizing from guestview. A guest can now be explicitly resized (in addition to autosizing) from guest_view.js, using the new |setSize| function. This new function combines autosizing and normal resizing, as described in: https://docs.google.com/document/d/1EJfmJSK0JJsxKptSRhepnsOOwvXJNv5nnJ1pZdjGDRQ BUG=434226 Committed: https://crrev.com/eb98f911ef43bf5463621031d0e79a98e061b3cb Cr-Commit-Position: refs/heads/master@{#312866}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased. #

Total comments: 4

Patch Set 3 : Addressed formatting nits. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -95 lines) Patch
M chrome/renderer/resources/extensions/extension_options.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 2 chunks +8 lines, -5 lines 0 comments Download
M extensions/browser/api/guest_view/guest_view_internal_api.h View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/browser/api/guest_view/guest_view_internal_api.cc View 1 chunk +25 lines, -12 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 1 5 chunks +23 lines, -8 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 8 chunks +70 lines, -29 lines 0 comments Download
M extensions/common/api/guest_view_internal.json View 3 chunks +14 lines, -7 lines 0 comments Download
M extensions/common/guest_view/guest_view_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/guest_view/guest_view_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/renderer/resources/guest_view/guest_view.js View 3 chunks +9 lines, -9 lines 0 comments Download
M extensions/renderer/resources/guest_view/guest_view_container.js View 1 2 chunks +12 lines, -6 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_attributes.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 1 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
paulmeyer
+fsamuel@
5 years, 11 months ago (2015-01-20 01:07:23 UTC) #4
Fady Samuel
I'll sign off on this once the previous patch lands but this generally looks good ...
5 years, 11 months ago (2015-01-20 01:13:19 UTC) #5
paulmeyer
ptal
5 years, 11 months ago (2015-01-22 20:16:00 UTC) #7
Fady Samuel
lgtm + nits https://codereview.chromium.org/857093003/diff/80001/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (left): https://codereview.chromium.org/857093003/diff/80001/content/renderer/browser_plugin/browser_plugin.cc#oldcode473 content/renderer/browser_plugin/browser_plugin.cc:473: delegate_->DidResizeElement( Is this change necessary? https://codereview.chromium.org/857093003/diff/80001/extensions/browser/extension_message_filter.cc ...
5 years, 11 months ago (2015-01-22 20:42:33 UTC) #8
Fady Samuel
lgtm + nits https://codereview.chromium.org/857093003/diff/80001/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (left): https://codereview.chromium.org/857093003/diff/80001/content/renderer/browser_plugin/browser_plugin.cc#oldcode473 content/renderer/browser_plugin/browser_plugin.cc:473: delegate_->DidResizeElement( Is this change necessary? https://codereview.chromium.org/857093003/diff/80001/extensions/browser/extension_message_filter.cc ...
5 years, 11 months ago (2015-01-22 20:42:33 UTC) #9
paulmeyer
https://codereview.chromium.org/857093003/diff/80001/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (left): https://codereview.chromium.org/857093003/diff/80001/content/renderer/browser_plugin/browser_plugin.cc#oldcode473 content/renderer/browser_plugin/browser_plugin.cc:473: delegate_->DidResizeElement( On 2015/01/22 20:42:33, Fady Samuel wrote: > Is ...
5 years, 11 months ago (2015-01-23 16:14:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857093003/120001
5 years, 11 months ago (2015-01-23 16:15:13 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:120001)
5 years, 11 months ago (2015-01-23 17:14:11 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 17:15:22 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/eb98f911ef43bf5463621031d0e79a98e061b3cb
Cr-Commit-Position: refs/heads/master@{#312866}

Powered by Google App Engine
This is Rietveld 408576698