Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: content/public/renderer/media_stream_audio_sink.cc

Issue 857093002: Set audio format before adding pepper sink to audio track. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More review comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/renderer/media_stream_audio_sink.h ('k') | content/renderer/media/webrtc_audio_capturer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/media_stream_audio_sink.cc
diff --git a/content/public/renderer/media_stream_audio_sink.cc b/content/public/renderer/media_stream_audio_sink.cc
index 5b14f95b4f254c09a5b98c95811fc7f8695ddb52..507bef0fa29c9e6cdb623e5fbc7f7ce8d497cc3f 100644
--- a/content/public/renderer/media_stream_audio_sink.cc
+++ b/content/public/renderer/media_stream_audio_sink.cc
@@ -43,4 +43,17 @@ void MediaStreamAudioSink::RemoveFromAudioTrack(
audio_track->RemoveSink(sink);
}
+media::AudioParameters MediaStreamAudioSink::GetFormatFromAudioTrack(
+ const blink::WebMediaStreamTrack& track) {
+ MediaStreamTrack* native_track = MediaStreamTrack::GetTrack(track);
+ if (!native_track->is_local_track()) {
+ LOG(ERROR) << "Can't get format from a remote audio track";
Avi (use Gerrit) 2015/01/27 23:25:17 Why LOG rather than DLOG? Especially since this wo
Anand Mistry (off Chromium) 2015/01/28 04:24:32 I don't know anything about webrtc, but presumably
+ return media::AudioParameters();
+ }
+
+ WebRtcLocalAudioTrack* audio_track =
+ static_cast<WebRtcLocalAudioTrack*>(native_track);
+ return audio_track->GetOutputFormat();
+}
+
} // namespace content
« no previous file with comments | « content/public/renderer/media_stream_audio_sink.h ('k') | content/renderer/media/webrtc_audio_capturer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698