content/renderer/media/webrtc_local_audio_track.h - Issue 857093002: Set audio format before adding pepper sink to audio track.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_local_audio_track.h

Issue 857093002: Set audio format before adding pepper sink to audio track. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/webrtc_audio_capturer.h ('K') | « content/renderer/media/webrtc_audio_capturer.cc ('k') | content/renderer/media/webrtc_local_audio_track.cc » ('j') | content/renderer/media/webrtc_local_audio_track.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_local_audio_track.h

diff --git a/content/renderer/media/webrtc_local_audio_track.h b/content/renderer/media/webrtc_local_audio_track.h

index 3c912ea03b0747ba97cb32d1cfbe75f02bc4d82f..9362b7ce95e749f86f56a20dbadcfe9e99116484 100644

--- a/content/renderer/media/webrtc_local_audio_track.h

+++ b/content/renderer/media/webrtc_local_audio_track.h

@@ -67,6 +67,11 @@ class CONTENT_EXPORT WebRtcLocalAudioTrack

webrtc::AudioTrackInterface* GetAudioAdapter() override;

+ // Returns the output format of the capture source. May return an invalid

+ // AudioParameters if the format is not yet available.

+ // Called on the main render thread.

+ const media::AudioParameters GetOutputFormat() const;

dmichael (off chromium) 2015/01/27 18:24:10 ditto, drop the const before the return type.

Anand Mistry (off Chromium) 2015/01/27 23:14:50 Done.

// Method called by the capturer to deliver the capture data.

// Called on the capture audio thread.

void Capture(const media::AudioBus& audio_bus,