Set audio format before adding pepper sink to audio track.

content/public/renderer/media_stream_audio_sink.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/renderer/media_stream_audio_sink.h"
 
 #include "base/logging.h"
 #include "content/renderer/media/media_stream_track.h"
 #include "content/renderer/media/webrtc_local_audio_track.h"
 #include "third_party/WebKit/public/platform/WebMediaStreamSource.h"
@@ skipping 25 matching lines @@
   if (!native_track->is_local_track()) {
     LOG(ERROR) << "Can't remove the sink from a remote audio track";
     return;
   }
 
   WebRtcLocalAudioTrack* audio_track =
       static_cast<WebRtcLocalAudioTrack*>(native_track);
   audio_track->RemoveSink(sink);
 }
 
+const media::AudioParameters& MediaStreamAudioSink::GetFormatFromAudioTrack(
+    const blink::WebMediaStreamTrack& track) {
+  // Invalid AudioParameters to return when track is remote. Needed because we
+  // return a reference.

[dmichael (off chromium), 2015/01/20 17:07:03]

I think it would be a lot better to just return by-value.

[Anand Mistry (off Chromium), 2015/01/27 02:12:10]

Done.

+  static const media::AudioParameters null_format;

[DaleCurtis, 2015/01/20 18:46:56]

This seems unnecessary, just return media::AudioParameters() below. Is there a
reason you are static const'ing for speed? :)

[Anand Mistry (off Chromium), 2015/01/27 02:12:10]

Because it needs to survive after the function call sicne it's returned by
reference. Removed since I'm now returning by value.

+  MediaStreamTrack* native_track = MediaStreamTrack::GetTrack(track);
+  if (!native_track->is_local_track()) {
+    LOG(ERROR) << "Can't get format from a remote audio track";
+    return null_format;
+  }
+
+  WebRtcLocalAudioTrack* audio_track =
+      static_cast<WebRtcLocalAudioTrack*>(native_track);
+  return audio_track->GetOutputFormat();
+}
+
 }  // namespace content