Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: components/printing/common/print_messages.h

Issue 857053002: Generate the print messages in components/printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/printing/common/print_messages.h
diff --git a/components/printing/common/print_messages.h b/components/printing/common/print_messages.h
index effc2f244abc3aeab9d86fe8b6079b3adfa335a3..de4e00555f6556ceb0af5dd2cf3a43e997604663 100644
--- a/components/printing/common/print_messages.h
+++ b/components/printing/common/print_messages.h
@@ -14,11 +14,15 @@
#include "printing/page_range.h"
#include "printing/page_size_margins.h"
#include "printing/print_job_constants.h"
+#include "printing/printing_param_traits_macros.h"
#include "third_party/WebKit/public/web/WebPrintScalingOption.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/ipc/gfx_param_traits.h"
#include "ui/gfx/native_widget_types.h"
+// Force multiple inclusion of the param traits file to generate all methods.
+#undef PRINTING_PRINTING_PARAM_TRAITS_MACROS_H_
dgn 2015/01/19 18:09:31 Inspired by: https://code.google.com/p/chromium/c
+
#ifndef COMPONENTS_PRINTING_COMMON_PRINT_MESSAGES_H_
#define COMPONENTS_PRINTING_COMMON_PRINT_MESSAGES_H_
@@ -86,13 +90,8 @@ struct PrintHostMsg_SetOptionsFromDocument_Params {
#define IPC_MESSAGE_START PrintMsgStart
-IPC_ENUM_TRAITS_MAX_VALUE(printing::MarginType,
Vitaly Buka (NO REVIEWS) 2015/01/21 00:59:59 do you need to them to separate file? can we just
dgn 2015/01/21 18:24:24 Then since they are processed by different generat
- printing::MARGIN_TYPE_LAST)
IPC_ENUM_TRAITS_MAX_VALUE(blink::WebPrintScalingOption,
blink::WebPrintScalingOptionLast)
-IPC_ENUM_TRAITS_MIN_MAX_VALUE(printing::DuplexMode,
- printing::UNKNOWN_DUPLEX_MODE,
- printing::SHORT_EDGE)
// Parameters for a render request.
IPC_STRUCT_TRAITS_BEGIN(PrintMsg_Print_Params)

Powered by Google App Engine
This is Rietveld 408576698