Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4500)

Unified Diff: chrome/common/BUILD.gn

Issue 857053002: Generate the print messages in components/printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/all_messages.h » ('j') | chrome/common/all_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 6fd61117e9a4a049e95fa4ef9036655bf05d7513..95c37706044cd764976239982ef25ee8f276837e 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -59,7 +59,6 @@ static_library("common") {
"//components/json_schema",
"//components/metrics",
"//components/policy:policy_component_common",
- "//components/printing/common:printing_common",
"//components/translate/core/common",
"//components/variations",
"//content/public/common",
@@ -136,13 +135,11 @@ static_library("common") {
}
# Printing.
- if (!enable_basic_printing && !enable_print_preview) {
- sources -= [
- "print_messages.cc",
- "print_messages.h",
+ if (enable_basic_printing || enable_print_preview) {
+ deps += [
+ "//components/printing/common:printing_common",
Vitaly Buka (NO REVIEWS) 2015/01/21 00:59:59 I guess printing_common should have printing in de
dgn 2015/01/22 00:14:29 But there are references to //printing directly, n
+ "//printing" ,
]
- } else {
- deps += [ "//printing" ]
if (enable_print_preview) {
# Full printing support.
sources += rebase_path(gypi_values.chrome_common_service_process_sources,
« no previous file with comments | « no previous file | chrome/common/all_messages.h » ('j') | chrome/common/all_messages.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698