Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 8570023: Add a guard page in front of metadata allocations. (Closed)

Created:
9 years, 1 month ago by jschuh
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add a guard page in front of metadata allocations. BUG=104752 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112260

Patch Set 1 : '' #

Patch Set 2 : '' #

Total comments: 8

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Total comments: 4

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -4 lines) Patch
M third_party/tcmalloc/chromium/src/common.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/page_heap_allocator.h View 1 2 3 4 5 6 2 chunks +15 lines, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/system-alloc.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/system-alloc.cc View 1 2 3 4 5 2 chunks +16 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/windows/port.cc View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jschuh
I played around with a few different ways of doing this, and this seems best. ...
9 years, 1 month ago (2011-11-18 18:58:06 UTC) #1
jar (doing other things)
http://codereview.chromium.org/8570023/diff/27001/third_party/tcmalloc/chromium/src/page_heap_allocator.h File third_party/tcmalloc/chromium/src/page_heap_allocator.h (right): http://codereview.chromium.org/8570023/diff/27001/third_party/tcmalloc/chromium/src/page_heap_allocator.h#newcode83 third_party/tcmalloc/chromium/src/page_heap_allocator.h:83: size_t guard_size = TCMalloc_SystemAddGuard(free_area_); Please pass in the allocated ...
9 years, 1 month ago (2011-11-23 23:46:14 UTC) #2
jschuh
Should be all good now. http://codereview.chromium.org/8570023/diff/27001/third_party/tcmalloc/chromium/src/page_heap_allocator.h File third_party/tcmalloc/chromium/src/page_heap_allocator.h (right): http://codereview.chromium.org/8570023/diff/27001/third_party/tcmalloc/chromium/src/page_heap_allocator.h#newcode83 third_party/tcmalloc/chromium/src/page_heap_allocator.h:83: size_t guard_size = TCMalloc_SystemAddGuard(free_area_); ...
9 years, 1 month ago (2011-11-24 00:05:26 UTC) #3
jar (doing other things)
http://codereview.chromium.org/8570023/diff/35006/third_party/tcmalloc/chromium/src/windows/port.cc File third_party/tcmalloc/chromium/src/windows/port.cc (right): http://codereview.chromium.org/8570023/diff/35006/third_party/tcmalloc/chromium/src/windows/port.cc#newcode268 third_party/tcmalloc/chromium/src/windows/port.cc:268: You need to exit if size < pagesize. You ...
9 years, 1 month ago (2011-11-24 00:30:54 UTC) #4
jschuh
Fixed. Guess I'm too focused on sneaking off for the long weekend. http://codereview.chromium.org/8570023/diff/35006/third_party/tcmalloc/chromium/src/windows/port.cc File third_party/tcmalloc/chromium/src/windows/port.cc ...
9 years, 1 month ago (2011-11-24 01:02:04 UTC) #5
jar (doing other things)
http://codereview.chromium.org/8570023/diff/33004/third_party/tcmalloc/chromium/src/page_heap_allocator.h File third_party/tcmalloc/chromium/src/page_heap_allocator.h (right): http://codereview.chromium.org/8570023/diff/33004/third_party/tcmalloc/chromium/src/page_heap_allocator.h#newcode87 third_party/tcmalloc/chromium/src/page_heap_allocator.h:87: result = free_area_; This code assumes that when we ...
9 years, 1 month ago (2011-11-24 01:08:07 UTC) #6
jschuh
Thanks. Right now these allocations are all large, compile-time constants, so I don't think there's ...
9 years ago (2011-11-28 18:33:36 UTC) #7
jar (doing other things)
LGTM
9 years ago (2011-11-30 17:24:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/8570023/41004
9 years ago (2011-11-30 17:36:18 UTC) #9
commit-bot: I haz the power
9 years ago (2011-11-30 18:57:05 UTC) #10
Change committed as 112260

Powered by Google App Engine
This is Rietveld 408576698