Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: src/debug.cc

Issue 85693002: Add versions with an Isolate parameter for inlined API methods that need one (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « include/v8.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3119 matching lines...) Expand 10 before | Expand all | Expand 10 after
3130 // DebugCommandProcessor goes here. 3130 // DebugCommandProcessor goes here.
3131 v8::Local<v8::Object> cmd_processor; 3131 v8::Local<v8::Object> cmd_processor;
3132 { 3132 {
3133 v8::Local<v8::Object> api_exec_state = 3133 v8::Local<v8::Object> api_exec_state =
3134 v8::Utils::ToLocal(Handle<JSObject>::cast(exec_state)); 3134 v8::Utils::ToLocal(Handle<JSObject>::cast(exec_state));
3135 v8::Local<v8::String> fun_name = v8::String::NewFromUtf8( 3135 v8::Local<v8::String> fun_name = v8::String::NewFromUtf8(
3136 isolate, "debugCommandProcessor"); 3136 isolate, "debugCommandProcessor");
3137 v8::Local<v8::Function> fun = 3137 v8::Local<v8::Function> fun =
3138 v8::Local<v8::Function>::Cast(api_exec_state->Get(fun_name)); 3138 v8::Local<v8::Function>::Cast(api_exec_state->Get(fun_name));
3139 3139
3140 v8::Handle<v8::Boolean> running = v8::Boolean::New(auto_continue); 3140 v8::Handle<v8::Boolean> running = v8::Boolean::New(isolate, auto_continue);
3141 static const int kArgc = 1; 3141 static const int kArgc = 1;
3142 v8::Handle<Value> argv[kArgc] = { running }; 3142 v8::Handle<Value> argv[kArgc] = { running };
3143 cmd_processor = v8::Local<v8::Object>::Cast( 3143 cmd_processor = v8::Local<v8::Object>::Cast(
3144 fun->Call(api_exec_state, kArgc, argv)); 3144 fun->Call(api_exec_state, kArgc, argv));
3145 if (try_catch.HasCaught()) { 3145 if (try_catch.HasCaught()) {
3146 PrintLn(try_catch.Exception()); 3146 PrintLn(try_catch.Exception());
3147 return; 3147 return;
3148 } 3148 }
3149 } 3149 }
3150 3150
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
3854 { 3854 {
3855 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3855 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3856 isolate_->debugger()->CallMessageDispatchHandler(); 3856 isolate_->debugger()->CallMessageDispatchHandler();
3857 } 3857 }
3858 } 3858 }
3859 } 3859 }
3860 3860
3861 #endif // ENABLE_DEBUGGER_SUPPORT 3861 #endif // ENABLE_DEBUGGER_SUPPORT
3862 3862
3863 } } // namespace v8::internal 3863 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « include/v8.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698