Issue 85693002: Add versions with an Isolate parameter for inlined API methods that need one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 85693002: Add versions with an Isolate parameter for inlined API methods that need one (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)

Modified:
7 years ago

Reviewers:
Sven Panne

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add versions with an Isolate parameter for inlined API methods that need one We shouldn't have APIs that call Isolate::GetCurrent() internally. This change removes all remaining occurrences of inlined methods in v8.h BUG=none R=svenpanne@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18058

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -7 lines)			Patch
M	include/v8.h	View	3 chunks	+16 lines, -3 lines	0 comments	Download
M	src/debug.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

7 years ago (2013-11-25 14:31:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18058 (presubmit successful).

Expand Messages | Collapse Messages