Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: content/renderer/media/webrtc_local_audio_renderer.h

Issue 856843002: Use audio shifter instead of a fifo for local mediastream playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment added Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/webrtc_local_audio_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webrtc_local_audio_renderer.h
diff --git a/content/renderer/media/webrtc_local_audio_renderer.h b/content/renderer/media/webrtc_local_audio_renderer.h
index e84545de372fcacf8f6dabd9d8384a85f99d0319..69e7c8cb13d2c5b78d1c01ce879548f1a47f362a 100644
--- a/content/renderer/media/webrtc_local_audio_renderer.h
+++ b/content/renderer/media/webrtc_local_audio_renderer.h
@@ -21,7 +21,7 @@
namespace media {
class AudioBus;
-class AudioFifo;
+class AudioShifter;
class AudioOutputDevice;
class AudioParameters;
}
@@ -120,8 +120,8 @@ class CONTENT_EXPORT WebRtcLocalAudioRenderer
// The sink (destination) for rendered audio.
scoped_refptr<media::AudioOutputDevice> sink_;
- // Contains copies of captured audio frames.
- scoped_ptr<media::AudioFifo> loopback_fifo_;
+ // This does all the synchronization/resampling/smoothing.
+ scoped_ptr<media::AudioShifter> audio_shifter_;
// Stores last time a render callback was received. The time difference
// between a new time stamp and this value can be used to derive the
@@ -142,7 +142,7 @@ class CONTENT_EXPORT WebRtcLocalAudioRenderer
// Set when playing, cleared when paused.
bool playing_;
- // Protects |loopback_fifo_|, |playing_| and |sink_|.
+ // Protects |audio_shifter_|, |playing_| and |sink_|.
mutable base::Lock thread_lock_;
// The preferred buffer size provided via the ctor.
« no previous file with comments | « no previous file | content/renderer/media/webrtc_local_audio_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698