Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 856813003: Revert of [turbofan] Improve memory layout of Node class. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Improve memory layout of Node class. (patchset #1 id:1 of https://codereview.chromium.org/828803004/) Reason for revert: Speculative revert to see if win XP recovers. Will reland if not. Original issue's description: > [turbofan] Improve memory layout of Node class. > > Also gets rid of the reinterpret_cast on this. > > R=svenpanne@chromium.org > > Committed: https://crrev.com/f91e8046fad99365c74ccbb39d42de58398dab57 > Cr-Commit-Position: refs/heads/master@{#26103} TBR=svenpanne@chromium.org,dcarney@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/dc6f34d83650dce8faa3e82e87c050f12732d4b3 Cr-Commit-Position: refs/heads/master@{#26106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/compiler/node.h View 2 chunks +9 lines, -10 lines 0 comments Download
M src/compiler/node.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [turbofan] Improve memory layout of Node class.
5 years, 11 months ago (2015-01-16 16:49:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856813003/1
5 years, 11 months ago (2015-01-16 16:49:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 16:50:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dc6f34d83650dce8faa3e82e87c050f12732d4b3 Cr-Commit-Position: refs/heads/master@{#26106}
5 years, 11 months ago (2015-01-16 16:50:19 UTC) #4
Michael Achenbach
5 years, 11 months ago (2015-01-16 19:17:26 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/855723002/ by machenbach@chromium.org.

The reason for reverting is: Revert didn't help..

Powered by Google App Engine
This is Rietveld 408576698