src/x64/macro-assembler-x64.cc - Issue 8568013: Introduce read buffer for external strings when using charAt (ia32).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 8568013: Introduce read buffer for external strings when using charAt (ia32). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: . Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index caca628f1fe9712ddf3c59a7c1991ad4055dff15..87e421c733a9c0bc7cae29e081f2b28dd976ecfb 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -4221,6 +4221,9 @@ void MacroAssembler::EnsureNotWhite(

testb(instance_type, Immediate(kExternalStringTag));

j(zero, &not_external, Label::kNear);

movq(length, Immediate(ExternalString::kSize));

+ testb(instance_type, Immediate(kBufferedStringTag));

+ j(zero, &is_data_object, Label::kNear);

+ movq(length, Immediate(ExternalString::kExtendedSize));

jmp(&is_data_object, Label::kNear);

bind(&not_external);

« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/string-externalize.js » ('j') | no next file with comments »