src/mips/macro-assembler-mips.cc - Issue 8568013: Introduce read buffer for external strings when using charAt (ia32).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/macro-assembler-mips.cc

Issue 8568013: Introduce read buffer for external strings when using charAt (ia32). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: . Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/macro-assembler-mips.cc

diff --git a/src/mips/macro-assembler-mips.cc b/src/mips/macro-assembler-mips.cc

index ccf048194c90a69c668311c03e6b588e6a4e92d1..a349ce05e01c55c5cb735d9417b96945cc3a7087 100644

--- a/src/mips/macro-assembler-mips.cc

+++ b/src/mips/macro-assembler-mips.cc

@@ -4892,6 +4892,9 @@ void MacroAssembler::EnsureNotWhite(

Label skip;

Branch(&skip, eq, t8, Operand(zero_reg));

li(length, ExternalString::kSize);

+ And(t8, instance_type, Operand(kBufferedStringTag));

+ Branch(&is_data_object, eq, t8, Operand(zero_reg));

+ li(length, ExternalString::kExtendedSize);

Branch(&is_data_object);

bind(&skip);

}

« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »