Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: src/extensions/externalize-string-extension.cc

Issue 8568013: Introduce read buffer for external strings when using charAt (ia32). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.h ('k') | src/heap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 return v8::ThrowException(v8::String::New( 93 return v8::ThrowException(v8::String::New(
94 "externalizeString() can't externalize twice.")); 94 "externalizeString() can't externalize twice."));
95 } 95 }
96 if (string->IsAsciiRepresentation() && !force_two_byte) { 96 if (string->IsAsciiRepresentation() && !force_two_byte) {
97 char* data = new char[string->length()]; 97 char* data = new char[string->length()];
98 String::WriteToFlat(*string, data, 0, string->length()); 98 String::WriteToFlat(*string, data, 0, string->length());
99 SimpleAsciiStringResource* resource = new SimpleAsciiStringResource( 99 SimpleAsciiStringResource* resource = new SimpleAsciiStringResource(
100 data, string->length()); 100 data, string->length());
101 result = string->MakeExternal(resource); 101 result = string->MakeExternal(resource);
102 if (result && !string->IsSymbol()) { 102 if (result && !string->IsSymbol()) {
103 HEAP->external_string_table()->AddString(*string); 103 if (string->IsSlicedString()) {
104 HEAP->external_string_table()->AddString(
105 SlicedString::cast(*string)->parent());
106 } else {
107 HEAP->external_string_table()->AddString(*string);
108 }
104 } 109 }
105 if (!result) delete resource; 110 if (!result) delete resource;
106 } else { 111 } else {
107 uc16* data = new uc16[string->length()]; 112 uc16* data = new uc16[string->length()];
108 String::WriteToFlat(*string, data, 0, string->length()); 113 String::WriteToFlat(*string, data, 0, string->length());
109 SimpleTwoByteStringResource* resource = new SimpleTwoByteStringResource( 114 SimpleTwoByteStringResource* resource = new SimpleTwoByteStringResource(
110 data, string->length()); 115 data, string->length());
111 result = string->MakeExternal(resource); 116 result = string->MakeExternal(resource);
112 if (result && !string->IsSymbol()) { 117 if (result && !string->IsSymbol()) {
113 HEAP->external_string_table()->AddString(*string); 118 if (string->IsSlicedString()) {
119 HEAP->external_string_table()->AddString(
120 SlicedString::cast(*string)->parent());
121 } else {
122 HEAP->external_string_table()->AddString(*string);
123 }
114 } 124 }
115 if (!result) delete resource; 125 if (!result) delete resource;
116 } 126 }
117 if (!result) { 127 if (!result) {
118 return v8::ThrowException(v8::String::New("externalizeString() failed.")); 128 return v8::ThrowException(v8::String::New("externalizeString() failed."));
119 } 129 }
120 return v8::Undefined(); 130 return v8::Undefined();
121 } 131 }
122 132
123 133
(...skipping 10 matching lines...) Expand all
134 144
135 void ExternalizeStringExtension::Register() { 145 void ExternalizeStringExtension::Register() {
136 static ExternalizeStringExtension* externalize_extension = NULL; 146 static ExternalizeStringExtension* externalize_extension = NULL;
137 if (externalize_extension == NULL) 147 if (externalize_extension == NULL)
138 externalize_extension = new ExternalizeStringExtension; 148 externalize_extension = new ExternalizeStringExtension;
139 static v8::DeclareExtension externalize_extension_declaration( 149 static v8::DeclareExtension externalize_extension_declaration(
140 externalize_extension); 150 externalize_extension);
141 } 151 }
142 152
143 } } // namespace v8::internal 153 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | src/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698