Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 856793002: Extend and fix tests for custom heap snapshot. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Extend and fix tests for custom heap snapshot. R=vogelheim@chromium.org Committed: https://crrev.com/a4a62c129bb572ad4525a36473501d484a6ea842 Cr-Commit-Position: refs/heads/master@{#26110}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -26 lines) Patch
M test/cctest/test-serialize.cc View 3 chunks +17 lines, -4 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/es6/iteration-syntax.js View 2 chunks +29 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 11 months ago (2015-01-16 12:19:29 UTC) #1
Yang
On 2015/01/16 12:19:29, Yang wrote: If we embed mjsunit.js into d8 and do not provide ...
5 years, 11 months ago (2015-01-16 12:20:48 UTC) #2
vogelheim
lgtm https://codereview.chromium.org/856793002/diff/1/test/mjsunit/debug-script.js File test/mjsunit/debug-script.js (right): https://codereview.chromium.org/856793002/diff/1/test/mjsunit/debug-script.js#newcode99 test/mjsunit/debug-script.js:99: var mjsunit_js_script = Debug.findScript(/debug-script.js/); nipitck: Change var name ...
5 years, 11 months ago (2015-01-16 12:37:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856793002/20001
5 years, 11 months ago (2015-01-16 13:26:45 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-16 22:17:46 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 22:18:37 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4a62c129bb572ad4525a36473501d484a6ea842
Cr-Commit-Position: refs/heads/master@{#26110}

Powered by Google App Engine
This is Rietveld 408576698