Issue 856783004: Revert of use log2(scale) to compute mip level

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 856783004: Revert of use log2(scale) to compute mip level (Closed)

Created:
5 years, 11 months ago by reed1

Modified:
5 years, 11 months ago

Reviewers:
jvanverth1, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of use log2(scale) to compute mip level (patchset #7 id:120001 of https://codereview.chromium.org/849333002/) Reason for revert: need more suppressions Original issue's description: > use log2(scale) to compute mip level > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/15fd47f8a07615a7f5d78581aee4c80ff9f17fd9 TBR=robertphillips@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b50ced703030dfbda4fc3ef5e6ec9a52fc0405f8

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -37 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	include/core/SkFloatingPoint.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	include/core/SkScalar.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/core/SkMipMap.cpp	View	2 chunks	+3 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856783004/1

5 years, 11 months ago (2015-01-16 15:27:40 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-16 15:27:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b50ced703030dfbda4fc3ef5e6ec9a52fc0405f8