Loading the Launcher with a Locked Profile launched UserManager.

chrome/browser/ui/app_list/app_list_service_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/app_list_service_impl.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/app_list/app_list_view_delegate.h"
 #include "chrome/browser/ui/app_list/profile_loader.h"
 #include "chrome/browser/ui/app_list/profile_store.h"
+#include "chrome/browser/ui/user_manager.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "ui/app_list/app_list_model.h"
 
 namespace {
 
 const int kDiscoverabilityTimeoutMinutes = 60;
 
 void SendAppListAppLaunch(int count) {
@@ skipping 55 matching lines @@
       : profile_manager_(profile_manager),
         weak_factory_(this) {
   }
 
   void AddProfileObserver(ProfileInfoCacheObserver* observer) override {
     profile_manager_->GetProfileInfoCache().AddObserver(observer);
   }
 
   void LoadProfileAsync(const base::FilePath& path,
                         base::Callback<void(Profile*)> callback) override {
+    if (IsProfileLocked(path)) {
+      UserManager::Show(base::FilePath(),

[tapted, 2015/01/19 22:25:50]

WDYT about just calling DismissAppList() before this?

i.e. still start showing it in AppListServiceMac::Init(), but fade it out before
any icons are loaded. I think that will simplify things a lot, and the user
might see a progress spinner slightly sooner. The app list icon doesn't bounce
in the Dock (Chrome does), so it's good to get some UI feedback going.

Then, I don't think you'd need to pass the extra argument to InitAll, and the
logic will just be in one place.

(also I think this should be in ProfileLoader - not ProfileStore - see below)

[Mike Lerman, 2015/01/21 21:54:13]

We discussed offline - shall leave it as is. If the UserManager's too slow to
load, that's its own problem ;)

+                        profiles::USER_MANAGER_NO_TUTORIAL,
+                        profiles::USER_MANAGER_SELECT_PROFILE_APP_LAUNCHER);
+      return;
+    }
+
     profile_manager_->CreateProfileAsync(
         path,
         base::Bind(&ProfileStoreImpl::OnProfileCreated,
                    weak_factory_.GetWeakPtr(),
                    callback),
         base::string16(),
         base::string16(),
         std::string());
   }
 
@@ skipping 10 matching lines @@
       case Profile::CREATE_STATUS_REMOTE_FAIL:
       case Profile::CREATE_STATUS_CANCELED:
         break;
       case Profile::MAX_CREATE_STATUS:
         NOTREACHED();
         break;
     }
   }
 
   Profile* GetProfileByPath(const base::FilePath& path) override {
+    if (IsProfileLocked(path))
+      return nullptr;

[tapted, 2015/01/19 22:25:51]

I'm a little wary of this - I don't think it's the right place. ProfileStoreImpl
is meant to be "dumb" since it's the part that isn't available to unit tests.

Can you modify ProfileLoader::LoadProfileInvalidatingOtherLoads() instead? I'm
pretty sure think that's the only place that uses ProfileLoader.

Then you can add `bool IsProfileLocked()` on ProfileLoader's interface, and have
it return a given value in tests.

[Mike Lerman, 2015/01/21 21:54:13]

Done.

     return profile_manager_->GetProfileByPath(path);
   }
 
   base::FilePath GetUserDataDir() override {
     return profile_manager_->user_data_dir();
   }
 
   bool IsProfileSupervised(const base::FilePath& profile_path) override {
     ProfileInfoCache& profile_info =
         g_browser_process->profile_manager()->GetProfileInfoCache();
     size_t profile_index = profile_info.GetIndexOfProfileWithPath(profile_path);
     return profile_index != std::string::npos &&
         profile_info.ProfileIsSupervisedAtIndex(profile_index);
   }
 
+  bool IsProfileLocked(const base::FilePath& profile_path) {
+    ProfileInfoCache& profile_info =
+        g_browser_process->profile_manager()->GetProfileInfoCache();
+    size_t profile_index = profile_info.GetIndexOfProfileWithPath(profile_path);
+    return profile_index != std::string::npos &&
+        profile_info.ProfileIsSigninRequiredAtIndex(profile_index);
+  }
+
  private:
   ProfileManager* profile_manager_;
   base::WeakPtrFactory<ProfileStoreImpl> weak_factory_;
 };
 
 void RecordAppListDiscoverability(PrefService* local_state,
                                   bool is_startup_check) {
   // Since this task may be delayed, ensure it does not interfere with shutdown
   // when they unluckily coincide.
   if (browser_shutdown::IsTryingToQuit())
@@ skipping 256 matching lines @@
   if (!base::MessageLoop::current())
     return;  // In a unit test.
 
   // Send app list usage stats after a delay.
   const int kSendUsageStatsDelay = 5;
   base::MessageLoop::current()->PostDelayedTask(
       FROM_HERE,
       base::Bind(&AppListServiceImpl::SendAppListStats),
       base::TimeDelta::FromSeconds(kSendUsageStatsDelay));
 }