Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 856693002: Combine element registries from sky-binder and sky-element. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Combine element registries from sky-binder and sky-element. We now have an element-registry.sky module that exposes API to register elements with attributes and event handlers. Right now it's an API on the module itself, eventually the module will export an ElementRegistry object since we'll need one per module once the custom element registry is one per module. R=abarth@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/956a552a2fb4e470003bd75ffb381fc42d30cac1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -149 lines) Patch
A sky/framework/sky-element/element-registry.sky View 1 chunk +148 lines, -0 lines 0 comments Download
M sky/framework/sky-element/sky-binder.sky View 5 chunks +9 lines, -54 lines 0 comments Download
M sky/framework/sky-element/sky-element.sky View 6 chunks +20 lines, -95 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-16 02:24:26 UTC) #1
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-16 02:50:27 UTC) #3
esprehn
5 years, 11 months ago (2015-01-16 04:31:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
956a552a2fb4e470003bd75ffb381fc42d30cac1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698