Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 85663003: We can actually map the Dart shift right to the JavaScript one under certain conditions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 30633)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)
@@ -221,6 +221,9 @@
// integer. Also, if we are using & with a positive constant we know
// that the result is positive already and need no conversion.
bool requiresUintConversion(HInstruction instruction) {
+ if (instruction is HShiftRight) {
+ return false;
+ }
if (instruction is HBitAnd) {
HBitAnd bitAnd = instruction;
if (isNonNegativeInt32Constant(bitAnd.left) ||
@@ -1277,6 +1280,7 @@
visitBitOr(HBitOr node) => visitBitInvokeBinary(node, '|');
visitBitXor(HBitXor node) => visitBitInvokeBinary(node, '^');
visitShiftLeft(HShiftLeft node) => visitBitInvokeBinary(node, '<<');
+ visitShiftRight(HShiftRight node) => visitBitInvokeBinary(node, '>>>');
visitNegate(HNegate node) => visitInvokeUnary(node, '-');
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698