Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 856583003: NaCl: Merge three global PP_Instance mappings into one (Closed)

Created:
5 years, 11 months ago by Mark Seaborn
Modified:
5 years, 11 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Merge three global PP_Instance mappings into one components/nacl/renderer/ had three mappings from PP_Instance IDs: * mapping to NexeLoadManager * mapping to JsonManifest * mapping to InstanceInfo Merging these into one will make it easier to add more per-PP_Instance state in the future. This also makes the lifetime of the objects mapped from PP_Instances clearer. This should fix a leak of InstanceInfo if untrusted code never calls the StartPpapiProxy IPC (though the IPC::ChannelHandle in it will still leak since this isn't owned). BUG=428030 TEST=NaCl tests in browser_tests Committed: https://crrev.com/9f45f6309ae6cbeaf1b08844f32c4579df3acf18 Cr-Commit-Position: refs/heads/master@{#312540}

Patch Set 1 #

Patch Set 2 : Fix + cleanup #

Patch Set 3 : Reinstate fix #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -108 lines) Patch
M components/nacl/renderer/json_manifest.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M components/nacl/renderer/json_manifest.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download
M components/nacl/renderer/nexe_load_manager.h View 2 chunks +1 line, -7 lines 0 comments Download
M components/nacl/renderer/nexe_load_manager.cc View 1 3 chunks +0 lines, -32 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 2 3 4 27 chunks +85 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
You might want to check that this has NULL checks in the places where they ...
5 years, 11 months ago (2015-01-21 22:13:46 UTC) #2
teravest
lgtm I agree this is clearer, thanks! The NULL checks look right to me.
5 years, 11 months ago (2015-01-21 23:47:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856583003/80001
5 years, 11 months ago (2015-01-22 01:00:16 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-22 02:42:12 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 02:43:07 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9f45f6309ae6cbeaf1b08844f32c4579df3acf18
Cr-Commit-Position: refs/heads/master@{#312540}

Powered by Google App Engine
This is Rietveld 408576698