Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: extensions/common/extension_messages.h

Issue 856563002: Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment by kalman@. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension_messages.h
diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h
index 9e3e6bba8703f39b92987b84a2eb1d3a2728e5c3..a9958a0d634f732603fb061026dc88fe5bd7628d 100644
--- a/extensions/common/extension_messages.h
+++ b/extensions/common/extension_messages.h
@@ -188,6 +188,24 @@ IPC_STRUCT_BEGIN(ExtensionMsg_ExternalConnectionInfo)
IPC_STRUCT_MEMBER(int, guest_process_id)
IPC_STRUCT_END()
+// Struct containing all the data needed to create a MimeHandlerViewGuest.
+IPC_STRUCT_BEGIN(ExtensionHostMsg_CreateMimeHandlerViewGuest_Params)
+ // The URL of the embedder.
+ IPC_STRUCT_MEMBER(std::string, embedder_url)
+
+ // The URL of the content.
+ IPC_STRUCT_MEMBER(std::string, content_url)
+
+ // The type fo the resource being loaded.
+ IPC_STRUCT_MEMBER(std::string, mime_type)
+
+ // A unique id for the element.
+ IPC_STRUCT_MEMBER(int, element_instance_id)
+
+ // The size of the element.
+ IPC_STRUCT_MEMBER(gfx::Size, element_size)
+IPC_STRUCT_END()
+
IPC_STRUCT_TRAITS_BEGIN(extensions::DraggableRegion)
IPC_STRUCT_TRAITS_MEMBER(draggable)
IPC_STRUCT_TRAITS_MEMBER(bounds)
@@ -798,12 +816,9 @@ IPC_MESSAGE_CONTROL4(ExtensionHostMsg_AttachGuest,
base::DictionaryValue /* attach_params */)
// Tells the browser to create a mime handler guest view for a plugin.
-IPC_MESSAGE_CONTROL5(ExtensionHostMsg_CreateMimeHandlerViewGuest,
+IPC_MESSAGE_CONTROL2(ExtensionHostMsg_CreateMimeHandlerViewGuest,
int /* render_frame_id */,
- std::string /* embedder_url */,
- std::string /* content_url */,
- std::string /* mime_type */,
- int /* element_instance_id */)
+ ExtensionHostMsg_CreateMimeHandlerViewGuest_Params)
Fady Samuel 2015/01/21 17:57:06 nit: Add /* params */ as a virtual variable name t
paulmeyer 2015/01/21 22:07:44 Acknowledged.
// Sent when a query selector request is made from the automation API.
// acc_obj_id is the accessibility tree ID of the starting element.

Powered by Google App Engine
This is Rietveld 408576698