Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: extensions/common/extension_messages.h

Issue 856563002: Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension_messages.h
diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h
index 9e3e6bba8703f39b92987b84a2eb1d3a2728e5c3..371ae52ef18d2d31a879fe137680f5003b8f1594 100644
--- a/extensions/common/extension_messages.h
+++ b/extensions/common/extension_messages.h
@@ -798,12 +798,10 @@ IPC_MESSAGE_CONTROL4(ExtensionHostMsg_AttachGuest,
base::DictionaryValue /* attach_params */)
// Tells the browser to create a mime handler guest view for a plugin.
-IPC_MESSAGE_CONTROL5(ExtensionHostMsg_CreateMimeHandlerViewGuest,
+IPC_MESSAGE_CONTROL3(ExtensionHostMsg_CreateMimeHandlerViewGuest,
int /* render_frame_id */,
- std::string /* embedder_url */,
- std::string /* content_url */,
- std::string /* mime_type */,
- int /* element_instance_id */)
+ int /* element_instance_id */,
+ base::DictionaryValue /* create_params */)
not at google - send to devlin 2015/01/20 18:32:16 why is this a dictionary rather than a typed objec
paulmeyer 2015/01/20 19:12:09 Because |create_params| needs to be a DictionaryVa
not at google - send to devlin 2015/01/20 19:30:09 Why did OnExtensionCreateMimeHandlerViewGuest chan
paulmeyer 2015/01/21 15:25:55 Okay, I replaced the DictionaryValue with an IPC s
// Sent when a query selector request is made from the automation API.
// acc_obj_id is the accessibility tree ID of the starting element.

Powered by Google App Engine
This is Rietveld 408576698