extensions/common/guest_view/guest_view_constants.cc - Issue 856563002: Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/guest_view/guest_view_constants.cc

Issue 856563002: Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Added a bit more infrastructure than in the previous patch. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/guest_view_base.cc ('K') | « extensions/common/guest_view/guest_view_constants.h ('k') | extensions/renderer/guest_view/extensions_guest_view_container.h » ('j') | extensions/renderer/resources/guest_view/guest_view.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/guest_view/guest_view_constants.cc

diff --git a/extensions/common/guest_view/guest_view_constants.cc b/extensions/common/guest_view/guest_view_constants.cc

index 465d6baaa1c3eb4e29a3391e9cf0302d91c68c7f..e04e7be1e2969eb464159fff23c3fa4aa3b9aa7c 100644

--- a/extensions/common/guest_view/guest_view_constants.cc

+++ b/extensions/common/guest_view/guest_view_constants.cc

@@ -6,15 +6,24 @@

namespace guestview {

-// Sizing Attributes.

+// Sizing attributes/parameters.

const char kAttributeAutoSize[] = "autosize";

const char kAttributeMaxHeight[] = "maxheight";

const char kAttributeMaxWidth[] = "maxwidth";

const char kAttributeMinHeight[] = "minheight";

const char kAttributeMinWidth[] = "minwidth";

+const char kElementWidth[] = "elementWidth";

+const char kElementHeight[] = "elementHeight";

+// Events.

+const char kEventResize[] = "guestViewInternal.onResize";

// Parameters/properties on events.

const char kIsTopLevel[] = "isTopLevel";

+const char kNewWidth[] = "newWidth";

+const char kNewHeight[] = "newHeight";

+const char kOldWidth[] = "oldWidth";

+const char kOldHeight[] = "oldHeight";

const char kReason[] = "reason";

const char kUrl[] = "url";

const char kUserGesture[] = "userGesture";