Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: extensions/renderer/guest_view/extensions_guest_view_container.cc

Issue 856563002: Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/guest_view/extensions_guest_view_container.h" 5 #include "extensions/renderer/guest_view/extensions_guest_view_container.h"
6 6
7 #include "content/public/renderer/render_frame.h" 7 #include "content/public/renderer/render_frame.h"
8 #include "content/public/renderer/render_view.h" 8 #include "content/public/renderer/render_view.h"
9 #include "extensions/common/extension_messages.h" 9 #include "extensions/common/extension_messages.h"
10 #include "extensions/common/guest_view/guest_view_constants.h" 10 #include "extensions/common/guest_view/guest_view_constants.h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 blink::WebScopedMicrotaskSuppression suppression; 134 blink::WebScopedMicrotaskSuppression suppression;
135 135
136 // Call the DetachGuest's callback. 136 // Call the DetachGuest's callback.
137 callback->Call(context->Global(), 0 /* argc */, NULL); 137 callback->Call(context->Global(), 0 /* argc */, NULL);
138 } 138 }
139 139
140 ExtensionsGuestViewContainer::ExtensionsGuestViewContainer( 140 ExtensionsGuestViewContainer::ExtensionsGuestViewContainer(
141 content::RenderFrame* render_frame) 141 content::RenderFrame* render_frame)
142 : GuestViewContainer(render_frame), 142 : GuestViewContainer(render_frame),
143 ready_(false), 143 ready_(false),
144 destruction_isolate_(nullptr) { 144 destruction_isolate_(nullptr),
145 element_resize_isolate_(nullptr) {
145 } 146 }
146 147
147 ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() { 148 ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {
148 if (element_instance_id() != guestview::kInstanceIDNone) { 149 if (element_instance_id() != guestview::kInstanceIDNone) {
149 g_guest_view_container_map.Get().erase(element_instance_id()); 150 g_guest_view_container_map.Get().erase(element_instance_id());
150 } 151 }
151 152
152 // Call the destruction callback, if one is registered. 153 // Call the destruction callback, if one is registered.
153 if (destruction_callback_.IsEmpty()) 154 if (destruction_callback_.IsEmpty())
154 return; 155 return;
155 v8::HandleScope handle_scope(destruction_isolate_); 156 v8::HandleScope handle_scope(destruction_isolate_);
156 v8::Handle<v8::Function> callback = 157 v8::Handle<v8::Function> callback =
157 destruction_callback_.NewHandle(destruction_isolate_); 158 destruction_callback_.NewHandle(destruction_isolate_);
158 v8::Handle<v8::Context> context = callback->CreationContext(); 159 v8::Handle<v8::Context> context = callback->CreationContext();
159 if (context.IsEmpty()) 160 if (context.IsEmpty())
160 return; 161 return;
161 162
162 v8::Context::Scope context_scope(context); 163 v8::Context::Scope context_scope(context);
163 blink::WebScopedMicrotaskSuppression suppression; 164 blink::WebScopedMicrotaskSuppression suppression;
164 165
165 callback->Call(context->Global(), 0, nullptr); 166 callback->Call(context->Global(), 0 /* argc */, nullptr);
166 } 167 }
167 168
168 ExtensionsGuestViewContainer* ExtensionsGuestViewContainer::FromID( 169 ExtensionsGuestViewContainer* ExtensionsGuestViewContainer::FromID(
169 int element_instance_id) { 170 int element_instance_id) {
170 ExtensionsGuestViewContainerMap* guest_view_containers = 171 ExtensionsGuestViewContainerMap* guest_view_containers =
171 g_guest_view_container_map.Pointer(); 172 g_guest_view_container_map.Pointer();
172 ExtensionsGuestViewContainerMap::iterator it = 173 ExtensionsGuestViewContainerMap::iterator it =
173 guest_view_containers->find(element_instance_id); 174 guest_view_containers->find(element_instance_id);
174 return it == guest_view_containers->end() ? NULL : it->second; 175 return it == guest_view_containers->end() ? NULL : it->second;
175 } 176 }
176 177
177 void ExtensionsGuestViewContainer::IssueRequest(linked_ptr<Request> request) { 178 void ExtensionsGuestViewContainer::IssueRequest(linked_ptr<Request> request) {
178 EnqueueRequest(request); 179 EnqueueRequest(request);
179 PerformPendingRequest(); 180 PerformPendingRequest();
180 } 181 }
181 182
182 void ExtensionsGuestViewContainer::RegisterDestructionCallback( 183 void ExtensionsGuestViewContainer::RegisterDestructionCallback(
183 v8::Handle<v8::Function> callback, 184 v8::Handle<v8::Function> callback,
184 v8::Isolate* isolate) { 185 v8::Isolate* isolate) {
185 destruction_callback_.reset(callback); 186 destruction_callback_.reset(callback);
186 destruction_isolate_ = isolate; 187 destruction_isolate_ = isolate;
187 } 188 }
188 189
190 void ExtensionsGuestViewContainer::RegisterElementResizeCallback(
191 v8::Handle<v8::Function> callback,
192 v8::Isolate* isolate) {
193 element_resize_callback_.reset(callback);
194 element_resize_isolate_ = isolate;
195 }
196
197 void ExtensionsGuestViewContainer::OnElementResize(const gfx::Size& old_size,
198 const gfx::Size& new_size) {
199 // Call the element resize callback, if one is registered.
200 if (element_resize_callback_.IsEmpty())
201 return;
202
203 v8::HandleScope handle_scope(element_resize_isolate_);
204 v8::Handle<v8::Function> callback =
205 element_resize_callback_.NewHandle(element_resize_isolate_);
206 v8::Handle<v8::Context> context = callback->CreationContext();
207 if (context.IsEmpty())
208 return;
209
210 const int argc = 4;
211 v8::Handle<v8::Value> argv[argc] = {
212 v8::Integer::New(element_resize_isolate_, old_size.width()),
213 v8::Integer::New(element_resize_isolate_, old_size.height()),
214 v8::Integer::New(element_resize_isolate_, new_size.width()),
215 v8::Integer::New(element_resize_isolate_, new_size.height())
216 };
217
218 v8::Context::Scope context_scope(context);
219 blink::WebScopedMicrotaskSuppression suppression;
220
221 callback->Call(context->Global(), argc, argv);
222 }
223
189 bool ExtensionsGuestViewContainer::OnMessageReceived( 224 bool ExtensionsGuestViewContainer::OnMessageReceived(
190 const IPC::Message& message) { 225 const IPC::Message& message) {
191 OnHandleCallback(message); 226 OnHandleCallback(message);
192 return true; 227 return true;
193 } 228 }
194 229
195 void ExtensionsGuestViewContainer::SetElementInstanceID( 230 void ExtensionsGuestViewContainer::SetElementInstanceID(
196 int element_instance_id) { 231 int element_instance_id) {
197 GuestViewContainer::SetElementInstanceID(element_instance_id); 232 GuestViewContainer::SetElementInstanceID(element_instance_id);
198 233
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 } 266 }
232 267
233 void ExtensionsGuestViewContainer::HandlePendingResponseCallback( 268 void ExtensionsGuestViewContainer::HandlePendingResponseCallback(
234 const IPC::Message& message) { 269 const IPC::Message& message) {
235 CHECK(pending_response_.get()); 270 CHECK(pending_response_.get());
236 linked_ptr<Request> pending_response(pending_response_.release()); 271 linked_ptr<Request> pending_response(pending_response_.release());
237 pending_response->HandleResponse(message); 272 pending_response->HandleResponse(message);
238 } 273 }
239 274
240 } // namespace extensions 275 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698