Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize()

extensions/renderer/resources/guest_view/guest_view_container.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements the shared functionality for different guestview
 // containers, such as web_view, app_view, etc.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestView = require('guestView').GuestView;
+var GuestViewInternalNatives = requireNative('guest_view_internal');
 var IdGenerator = requireNative('id_generator');
 
 function GuestViewContainer(element, viewType) {
   privates(element).internal = this;
   this.element = element;
   this.elementAttached = false;
   this.guest = new GuestView(viewType);
   this.viewInstanceId = IdGenerator.GetNextId();
   this.viewType = viewType;
 
   privates(this).browserPluginElement = this.createBrowserPluginElement();
   this.setupFocusPropagation();
 
   var shadowRoot = this.element.createShadowRoot();
   shadowRoot.appendChild(privates(this).browserPluginElement);
+
+  // Track when the element resizes using the element resize callback.
+  if (this.internalInstanceId) {
+  GuestViewInternalNatives.RegisterElementResizeCallback(

[Fady Samuel, 2015/01/19 23:57:01]

nit: spacing.

[Fady Samuel, 2015/01/20 00:04:25]

This needs to be called every time we get a new internalinstanceid.

[paulmeyer, 2015/01/20 00:24:38]

Done.

[paulmeyer, 2015/01/20 00:24:38]

Done.

+      this.internalInstanceId, this.onElementResize.bind(this));
+  }
 }
 
 // Forward public API methods from |proto| to their internal implementations.
 GuestViewContainer.forwardApiMethods = function(proto, apiMethods) {
   var createProtoHandler = function(m) {
     return function(var_args) {
       var internal = privates(this).internal;
       return $Function.apply(internal[m], internal, arguments);
     };
   };
@@ skipping 71 matching lines @@
                       this.buildAttachParams());
   }
 };
 
 // Implemented by the specific view type, if needed.
 GuestViewContainer.prototype.buildAttachParams = function() { return {}; };
 GuestViewContainer.prototype.handleAttributeMutation = function() {};
 GuestViewContainer.prototype.onElementAttached = function() {};
 GuestViewContainer.prototype.onElementDetached = function() {
   this.guest.destroy();
 };

[Fady Samuel, 2015/01/19 23:57:01]

nit: Add a blank line after this.

[paulmeyer, 2015/01/20 00:24:38]

onElementResize() is still a function that will be overridden by a specific view
type.

+GuestViewContainer.prototype.onElementResize = function(oldWidth, oldHeight,
+                                                        newWidth, newHeight) {
+  // TODO(paulmeyer): If any code is entered here, and this function is called
+  // while the dev-tool inspect window is open, chrome will crash.
+};
 
 // Registers the browser plugin <object> custom element. |viewType| is the
 // name of the specific guestview container (e.g. 'webview').
 function registerBrowserPluginElement(viewType) {
   var proto = Object.create(HTMLObjectElement.prototype);
 
   proto.createdCallback = function() {
     this.setAttribute('type', 'application/browser-plugin');
     this.setAttribute('id', 'browser-plugin-' + IdGenerator.GetNextId());
     this.style.width = '100%';
@@ skipping 73 matching lines @@
   // Delete the callbacks so developers cannot call them and produce unexpected
   // behavior.
   delete proto.createdCallback;
   delete proto.attachedCallback;
   delete proto.detachedCallback;
   delete proto.attributeChangedCallback;
 }
 
 // Exports.
 exports.GuestViewContainer = GuestViewContainer;