Added the infrastructure for surfaceProxy.onResize() and SurfaceView.onResize()

extensions/renderer/resources/guest_view/guest_view_container.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements the shared functionality for different guestview
 // containers, such as web_view, app_view, etc.
 
 var DocumentNatives = requireNative('document_natives');
+var EventBindings = require('event_bindings');
 var GuestView = require('guestView').GuestView;
+var GuestViewInternalNatives = requireNative('guest_view_internal');
 var IdGenerator = requireNative('id_generator');
 
 function GuestViewContainer(element, viewType) {
   privates(element).internal = this;
   this.element = element;
   this.elementAttached = false;
   this.guest = new GuestView(viewType);
   this.viewInstanceId = IdGenerator.GetNextId();
   this.viewType = viewType;
 
   privates(this).browserPluginElement = this.createBrowserPluginElement();
   this.setupFocusPropagation();
 
   var shadowRoot = this.element.createShadowRoot();
   shadowRoot.appendChild(privates(this).browserPluginElement);
+
+  this.setupResizeEvents();
 }
 
 // Forward public API methods from |proto| to their internal implementations.
 GuestViewContainer.forwardApiMethods = function(proto, apiMethods) {
   var createProtoHandler = function(m) {
     return function(var_args) {
       var internal = privates(this).internal;
       return $Function.apply(internal[m], internal, arguments);
     };
   };
@@ skipping 39 matching lines @@
   this.element.addEventListener('focus', function(e) {
     // Focus the BrowserPlugin when the GuestViewContainer takes focus.
     privates(this).browserPluginElement.focus();
   }.bind(this));
   this.element.addEventListener('blur', function(e) {
     // Blur the BrowserPlugin when the GuestViewContainer loses focus.
     privates(this).browserPluginElement.blur();
   }.bind(this));
 };
 
+GuestViewContainer.prototype.setupResizeEvents = function() {
+  // Track when the guest resizes using the onResize event.
+  var CreateEvent = function(name) {
+    var eventOpts = {supportsListeners: true, supportsFilters: true};
+    return new EventBindings.Event(name, undefined, eventOpts);
+  };
+  var resizeEvent = CreateEvent('guestViewInternal.onResize');

[Fady Samuel, 2015/01/15 21:40:12]

Remove this for now? This doesn't seem to do anything in this patch?

[paulmeyer, 2015/01/19 23:45:35]

Moved to guest_view.js, as discussed offline.

+  resizeEvent.addListener(function(e) {
+    this.onGuestResize(e.oldWidth, e.oldHeight, e.newWidth, e.newHeight);
+  }.bind(this), {instanceId: this.viewInstanceId});
+
+  // Track when the element resizes using the element resize callback.
+  GuestViewInternalNatives.RegisterElementResizeCallback(
+      this.internalInstanceId, this.onElementResize.bind(this));
+};
+
 GuestViewContainer.prototype.attachWindow = function() {
   if (!this.internalInstanceId) {
     return true;
   }
 
   this.guest.attach(this.internalInstanceId,
                     this.viewInstanceId,
                     this.buildAttachParams());
   return true;
 };
@@ skipping 13 matching lines @@
   }
 };
 
 // Implemented by the specific view type, if needed.
 GuestViewContainer.prototype.buildAttachParams = function() { return {}; };
 GuestViewContainer.prototype.handleAttributeMutation = function() {};
 GuestViewContainer.prototype.onElementAttached = function() {};
 GuestViewContainer.prototype.onElementDetached = function() {
   this.guest.destroy();
 };
+GuestViewContainer.prototype.onElementResize = function(oldWidth, oldHeight,
+                                                        newWidth, newHeight) {};
+GuestViewContainer.prototype.onGuestResize = function(oldWidth, oldHeight,
+                                                      newWidth, newHeight) {};
 
 // Registers the browser plugin <object> custom element. |viewType| is the
 // name of the specific guestview container (e.g. 'webview').
 function registerBrowserPluginElement(viewType) {
   var proto = Object.create(HTMLObjectElement.prototype);
 
   proto.createdCallback = function() {
     this.setAttribute('type', 'application/browser-plugin');
     this.setAttribute('id', 'browser-plugin-' + IdGenerator.GetNextId());
     this.style.width = '100%';
@@ skipping 73 matching lines @@
   // Delete the callbacks so developers cannot call them and produce unexpected
   // behavior.
   delete proto.createdCallback;
   delete proto.attachedCallback;
   delete proto.detachedCallback;
   delete proto.attributeChangedCallback;
 }
 
 // Exports.
 exports.GuestViewContainer = GuestViewContainer;